Fix out-by-one error - #5790
Merged
dmarcos merged 1 commit intoFeb 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
diarmidmackenzie
marked this pull request as draft
February 5, 2026 15:24
diarmidmackenzie
marked this pull request as ready for review
February 5, 2026 15:24
Copy link
Copy Markdown
Contributor
|
works |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
As described in issue #5789
Changes proposed:
Fix out by 1 error, so pixel row 0 swaps with row (height -1) not (height) and vice-versa.
Also simplified code & reduced calculations by pre-computing the start and end indices.
Testing
Before fix: I took a screenshot from the Anime UI example and opened in Paint. You can see a single layer of blank pixels at the top of the image:
After fix: no blank row of pixels at the top or bottom of the image: