Export shared ko apply helper - #1255
Open
Minsoo Kim (33modeling) wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sorry, something went wrong.
Preserve the shared fixture migration from main and route its ko apply call through the exported helper. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Export KoApply from the shared E2E package and reuse it in the egress authorization suite, so the pinned ko wrapper, repository configuration path, and Kubernetes context are constructed in one place.
Update the shared fixture and server-pod callers to the exported name. The sizing, capabilities, and probe paths retain main's DeploySubstrateFixture migration and use the helper through that shared path.
Fixes #1251
Testing
Go 1.27.1: env -u NO_COLOR go test ./internal/e2e ./internal/e2e/suites/sizing ./internal/e2e/suites/egressauthz ./internal/e2e/suites/capabilities passed. The E2E suites compile but their TestMain skips cluster execution without --e2e; this is not a live-cluster E2E result.
gofmt -l on the four changed files: clean.
Diff against updated main: four files, six insertions and ten deletions; git diff --check passed.
The helper implementation is unchanged except for its exported name; migrated probe/sizing/capabilities files match main.
make verify: the race-test phase passed 100 packages and failed only TestEnvoyDrainerReachesIPv6OnlyAdmin in cmd/atenet/internal/router. The same test fails on unmodified main (721152f14) with the same IPv6 loopback assertion in this environment. Full verification is not claimed to pass.
Static checks passed: boilerplate, code generation, Go modules, Go formatting, golangci-lint, Kubernetes API lint, Go/Python licenses, PostgreSQL migrations, and threat-model validation.
Remaining static checks could not run here: metrics requires Weaver or Docker; proto formatting requires clang-format; shell checking requires shellcheck or Docker. No metrics, proto, or shell files are changed by this PR.
AI disclosure
OpenAI Codex assisted with the original change and this conflict-resolution update, inspected the diff, and ran the listed checks. Google CLA remains pending.