fix: recover from oversized JSON-RPC frames - #111
Merged
PsiACE merged 2 commits intoJun 29, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
frostming
reviewed
Jun 12, 2026
Comment thread
src/acp/connection.py
Outdated
| consumed = 1 | ||
| if consumed > 0: | ||
| try: | ||
| await self._wait_for_reader(self._reader.readexactly(consumed)) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Should we handle TimeoutError?
Sorry, something went wrong.
frostming
reviewed
Jun 12, 2026
Comment thread
src/acp/connection.py
Outdated
| except asyncio.IncompleteReadError as exc: | ||
| return exc.partial | ||
| except asyncio.LimitOverrunError as exc: | ||
| await self._discard_oversized_line(exc.consumed) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Instead of dropping the line and emit a warning, how about we read maximum limit bytes and concatenate the result manually?
Sorry, something went wrong.
PsiACE
marked this pull request as ready for review
June 25, 2026 08:50
1napz
suggested changes
Jun 26, 2026
1napz
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
🔨🔨🔨
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
Close #62
Testing
Docs & screenshots
Checklist