FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Increase default stdio buffer limit and allow configuration by jacoblee93 · Pull Request #59 · agentclientprotocol/python-sdk · GitHub

/ python-sdk Public

feat: Increase default stdio buffer limit and allow configuration - #59

Merged
PsiACE merged 3 commits into
agentclientprotocol:mainfrom
jacoblee93:jacob/transfer
Jan 31, 2026
ConversationCommits (3)ChecksFiles changed
Merged

feat: Increase default stdio buffer limit and allow configuration#59
PsiACE merged 3 commits into
agentclientprotocol:mainfrom
jacoblee93:jacob/transfer

Conversation

jacoblee93 commented Jan 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

The default stdio stream buffer size is only 64kb, which means you get errors like this when trying to send messages larger than that via ACP:

Filesizes above that are quite common for multimodal data

The new default of 50MB should handle most practical multimodal cases. Definitely open to tweaking this default though if anyone has strong feelings! And it's now configurable if needed

Related issues

Testing

Added tests and ran appropriate make commands

Docs & screenshots

Not sure how to best document, assuming this will automatically propagate to API refs?

Checklist

  • Conventional Commit title (e.g. feat:, fix:).
  • Tests cover the change or are not required (explain above).
  • Docs/examples updated when behaviour is user-facing.
  • Schema regenerations (make gen-all) are called out if applicable.

PsiACE commented Jan 30, 2026

Copy link
Copy Markdown
Member

Thanks for your PR. The default 50MB limit doesn't seem reasonable. I think it's sufficient to just allow it to be configured.

phil65 commented Jan 30, 2026

Copy link
Copy Markdown

@PsiACE I would at least increase the default limit to at least 1MB or sth.. its quite easy to reach the 64kb when it comes to sending the models and slash commands (model lists can easily reach 1000 items for some agents)

PsiACE approved these changes Jan 31, 2026
View reviewed changes

PsiACE left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thanks @phil65, i will merge it first and consider a small and enough default value. and cc @stdrc for suggestion

PsiACE merged commit 5510db2 into agentclientprotocol:main Jan 31, 2026
8 checks passed

jacoblee93 commented Jan 31, 2026

Copy link
Copy Markdown
Contributor Author

Thank you! Yeah 50MB is probably more than needed outside of niche cases. I've seen some screenshots around 5MB though so wouldn't go too small.

PsiACE commented Jan 31, 2026

Copy link
Copy Markdown
Member

Thank you! Yeah 50MB is probably more than needed outside of niche cases. I've seen some screenshots around 5MB though so wouldn't go too small.

talked with stdrc, i will keep 50MB as default

PsiACE mentioned this pull request Feb 7, 2026
Closed
1 task
koriyoshi2041 mentioned this pull request Mar 3, 2026
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

PsiACE PsiACE approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL