fix: Add SessionInfoUpdate to SessionUpdate type in helpers - #61
Merged
PsiACE merged 2 commits intoFeb 7, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Chojan Shang <psiace@apache.org>
PsiACE
approved these changes
Feb 7, 2026
PsiACE
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
thanks. lgtm
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SessionUpdate type in helpers is inconsistent with the type of the update arg in Client.session_update, missing SessionInfoUpdate variant. I assume the helpers should align to the Client Protocol, so I add the missing variant into helpers.
Related issues
Testing
Docs & screenshots
Checklist