Remove em-dashes from served discovery copy (2.7.2) - #122
Merged
vvillait88 merged 2 commits intoAug 22, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Mirror of the Node SDK change, string for string, so both render the same shared identity and payment blocks. Every string these builders emit onto a merchant's llms.txt, skill.md, OpenAPI and 402 body is now free of em-dashes, which the house rule bars on external surfaces. The empty compatible-clients table cell rendered a bare em-dash; it now reads "none", matching the Node SDK. Also corrects "agent-commerce" to "agentic-commerce" in five docstrings: that is the house category term. Docstrings and comments are otherwise untouched: internal prose, not served, and they carry the rationale. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror of the Node SDK change, string for string, so both SDKs keep rendering the same shared identity and payment blocks. Every string these builders emit onto a merchant's llms.txt, skill.md, OpenAPI document and 402 body is now free of em-dashes, which the house style bars on external surfaces.
Two worth calling out:
Docstrings and comments are otherwise untouched: internal prose, never served, and they carry the rationale. Note that Python docstrings are not automatically published here the way a FastAPI route docstring is, so the served set is just the string literals in the builders.
Type of change
Public API
No signature, shape, or export changes. The rendered TEXT of discovery surfaces changes, which is the point. A consumer asserting on the exact old wording of a shared identity or payment line would need to update; nothing else is affected. Version bumped 2.7.1 to 2.7.2, patch, since client impact is text only.
Test plan
uv run ruff check ., uv run ruff format --check ., uv run pytest: 1863 passing, 4 skipped, coverage 95.37% against the 95% floor.
Cross-checked against the Node SDK line by line so the two do not drift: the same twenty-one strings, the same replacements, the same none placeholder. One string in this copy was initially missed that the Node copy had fixed (the SPT rail identity-gating line); caught by diffing the two builders against each other rather than by re-reading either one alone.
Checklist