Corrected cross_validation function procedure - #1009
Closed
uchihabloodline wants to merge 1 commit into
Closed
uchihabloodline wants to merge 1 commit into
uchihabloodline wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
corrected the function procedure as according to the standardized approaches.
antmarakis
reviewed
Jan 30, 2019
Comment thread
learning.py
| random.shuffle(dataset.examples) | ||
| for fold in range(k): | ||
| random.shuffle(dataset.examples) | ||
|
|
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Please remove the empty line here.
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
please check #1028
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks @uchihabloodline. cross_validation was reimplemented in the learning.py refactor, so this 2019 shuffle change no longer applies. Closing as superseded — thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corrected the function procedure as according to the standardized approaches.