FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add chapter 18 and 19 for 4th edition by bruceyoungsysu · Pull Request #1076 · aimacode/aima-python · GitHub

  1. aimacode
  2. aima-python

Repository navigation

add chapter 18 and 19 for 4th edition - #1076

Merged
delaray merged 26 commits into
aimacode:masterfrom
bruceyoungsysu:learning
Aug 5, 2019
ConversationCommits (26)ChecksFiles changed
Merged

add chapter 18 and 19 for 4th edition#1076
delaray merged 26 commits into
aimacode:masterfrom
bruceyoungsysu:learning

Conversation

bruceyoungsysu commented Jun 16, 2019

Copy link
Copy Markdown
Contributor
  • added util functions
  • added and modified chapter 18 functions following the book.
  • added test file

antmarakis reviewed Jun 20, 2019
View reviewed changes
Comment thread DeepNeuralNet4e.py


def simple_rnn_learner(train_data, val_data, epochs=2):

antmarakis Jun 20, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It would be great if you could add some description of the function, detailing what it does (is it just a general network?), what is the format of the data, etc. Right now it's hard to discern what this is trying to accomplish.

bruceyoungsysu Jun 21, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the reminder! I will also check other functions for the necessary comments.

bruceyoungsysu changed the title chapter 18 learning from examples add chapter 18 and 19 Jun 23, 2019

delaray commented Jun 30, 2019

Copy link
Copy Markdown
Contributor

@bruceyoungsysu : Hi Bruce. There is one failing continuous integration test below. Can you fix this before I approve your pull request. I've attached a screen shot of the error.

bruceyoungsysu changed the title add chapter 18 and 19 add chapter 18 and 19 for 4th edition Jul 26, 2019
delaray merged commit 809988d into aimacode:master Aug 5, 2019

delaray commented Aug 5, 2019

Copy link
Copy Markdown
Contributor

Merged into master.

dj5x5 pushed a commit to dj5x5/aima-python that referenced this pull request Jul 17, 2025
add chapter 18 and 19 for 4th edition (aimacode#1076)
7265818 
* chapter 18 learning

* add chapter 19

* move init dataset in NN learner

* add adam optimizer, add nn learner

* remove cpt 19 for debug

* change while loop in games4e

* add chapter 19

* add sgd and adam optimizer

* add chpt19 deep nn

* add rnn

* add auto encoder

* add comments, correct tests

* add more comments, change algorithms according to orders of chapter sections

* add keras and numpy to requirements

* add tf as requirement

* add gc in test agent

* fix agent bugs for running test_agent and test_agent_4e together

* fix build error

* add chapter 21 and 22

* add chapter 12 and part of 13

* remove chapter 12 and 13, add test of rl

* modify rnn test

* fix build error

* Update utils4e.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

antmarakis antmarakis left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL