fixed grabbing behaviour in agent by omar-3 · Pull Request #1148 · aimacode/aima-python · GitHub

When a thing is grabbed, it would be hidden from the environment. When released or the agent is removed it would be added to environment again at the same location of the agent. For the issue of grabbed thing movement, it is already implemented. No test has failed.

Have I missed something?

Thanks! I have suggested a couple of improvements. Can you please review them?

This line if things should be on the top otherwise things[0] (accessed in the line above) would raise an exception!

yes that is true

I don't see a reason to comment these lines out. Even though the second line is redundant, the observers of the environment still need to be informed about each thing being deleted.

if we delete all of the agent holdings with del thing.holding, and thanks to python memory management. All instants of the agent's holding would vanish from memory even in the observer list. Tell me what you think.

The observers of the environment need to be updated about all the things getting deleted along with the agent. I have not seen observers used anywhere, so it depends upon the maintainers of the project to keep or exclude it!

I think this will also need some tests to be added

I think this will also need some tests to be added

Ahh I realized that after making the pull request, the tests would be easy I guess.

could anyone help me understand why the checks have failed? It fails for python3.4 only

could anyone help me understand why the checks have failed? It fails for python3.4 only

It has nothing to do with the pr. Just close and reopen and the tests will hopefully pass...

Turns out pyyaml has removed support for python 3.4. This is a issue for keras. We don't need to worry about it.

Here's the upstream issue on keras. gh-13674

I guess it is better if I open an issue.

@Okhaledzaki I don't think this is our issue but I will leave it upto the maintainers to decide!

I think the if statement could be streamlined if we rewrote it as:

if action in ['TurnRight', 'TurnLeft', 'Forward']:
            super().execute_action(agent,action)
            agent.performance -= 1
elif action == 'Grab':
            super().execute_action(agent,action)

I think the above looks a bit better.

I had that in mind, but I thought to myself that being more articulate and reasonably redundant in code would help the student retaining the information that is my case.

But actually seeing it, it really didn't help much.

Some minor typos.

A space is needed after the last comma.

done

something has broken in the deeplearning module @antmarakis :"D

@antmarakis The tests have all passed finally phew

You need a space after the comma, to comply with the overall project style.

done

* fixed grabbing behaviour in agent * fixed the grabbing issues and itegrated into wumpus environment * cleaned the code a bit * fixing the code space formatting * fixing format

fixed grabbing behaviour in agent

e2a2bf6

tirthasheshpatel suggested changes Jan 7, 2020

View reviewed changes

fixed the grabbing issues and itegrated into wumpus environment

f660166

omar-3 closed this Jan 7, 2020

omar-3 reopened this Jan 7, 2020

omar-3 closed this Jan 7, 2020

omar-3 reopened this Jan 7, 2020

This was referenced Jan 8, 2020

PR #1148 #1149

Closed

fixed typos in gui folder #1150

Merged

omar-3 requested a review from antmarakis February 7, 2020 07:03

antmarakis reviewed Feb 16, 2020

View reviewed changes

cleaned the code a bit

6da942d

omar-3 requested a review from antmarakis February 18, 2020 20:30

antmarakis reviewed Feb 20, 2020

View reviewed changes

fixing the code space formatting

679ab34

omar-3 requested a review from antmarakis February 20, 2020 20:28

antmarakis closed this Feb 21, 2020

antmarakis reopened this Feb 21, 2020

antmarakis closed this Feb 23, 2020

antmarakis reopened this Feb 23, 2020

omar-3 closed this Feb 24, 2020

omar-3 reopened this Feb 24, 2020

omar-3 closed this Feb 24, 2020

omar-3 reopened this Feb 24, 2020

antmarakis reviewed Mar 6, 2020

View reviewed changes

fixing format

2018895

omar-3 requested a review from antmarakis March 6, 2020 17:52

antmarakis merged commit f502be9 into aimacode:master Mar 18, 2020

omar-3 deleted the fix-grab-agent branch April 21, 2020 18:44

+                      elif action == 'Grab':
+                          things = [thing for thing in self.list_things_at(agent.location)]
+                          if agent.can_grab(things[0]):
+                              if things:

+                          # for obj in thing.holding:
+                          #     super().delete_thing(obj)
+                          #     for obs in self.observers:
+                          #         obs.thing_deleted(obj)

-                              if len(things):
-                                  agent.holding.append(things[0])
+                      if action in ['TurnRight', 'TurnLeft', 'Forward', 'Grab']:
+                          super().execute_action(agent,action)

		@@ -967,21 +967,16 @@ def execute_action(self, agent, action):

		agent.bump = False
		if action == 'TurnRight':

fixed grabbing behaviour in agent by omar-3 · Pull Request #1148 · aimacode/aima-python · GitHub

fixed grabbing behaviour in agent - #1148

fixed grabbing behaviour in agent#1148antmarakis merged 5 commits intoaimacode:masteraimacode/aima-python:masterfrom omar-3:fix-grab-agentomar-3/aima-python:fix-grab-agentCopy head branch name to clipboard

Conversation

omar-3 commented Jan 7, 2020

Uh oh!

tirthasheshpatel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tirthasheshpatel commented Jan 7, 2020

Uh oh!

omar-3 commented Jan 7, 2020

Uh oh!

omar-3 commented Jan 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tirthasheshpatel commented Jan 7, 2020

Uh oh!

tirthasheshpatel commented Jan 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tirthasheshpatel commented Jan 7, 2020

Uh oh!

omar-3 commented Jan 7, 2020

Uh oh!

tirthasheshpatel commented Jan 8, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

antmarakis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

omar-3 commented Feb 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omar-3 commented Feb 27, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fixed grabbing behaviour in agent#1148
antmarakis merged 5 commits into
aimacode:masterfrom
omar-3:fix-grab-agent

omar-3 commented Jan 7, 2020 •
edited
Loading

tirthasheshpatel commented Jan 7, 2020 •
edited
Loading

omar-3 commented Feb 21, 2020 •
edited
Loading