FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

added examples to notebooks LOGIC & PLANNING by sofmonk · Pull Request #427 · aimacode/aima-python · GitHub

Repository navigation

added examples to notebooks LOGIC & PLANNING - #427

Closed
sofmonk wants to merge 7 commits into
aimacode:masterfrom
sofmonk:sofmonk-patch-1
Closed

sofmonk wants to merge 7 commits into
aimacode:masterfrom
sofmonk:sofmonk-patch-1

Conversation

sofmonk commented Mar 27, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. added examples to logic.ipynb:
  • PropKB
  • tt_entail
  • tt_check_all
  • dpll_satisfiable
  • WalkSAT
  • SATplan
  • unify
  1. added examples to planning.ipynb:
  • factored state representation
  • PDLL
  • Actions
  • Air_cargo_problem
  • DWR (dock worker robot) problem
  • spare_tire_problem
  • blocks_world

Sir, I found some examples/diagrams from the other websites good, but I didn't include them as I was skeptical if we can add content from other websites. Please let me know so that I can add them?

sofmonk added 2 commits March 27, 2017 11:42
    added examples to planning.ipynb:

    PDLL
    Actions
    Air_cargo_problem
    spare_tire_problem
    blocks_world
added examples to logic.ipynb:

    PropKB
    tt_entail
    tt_check_all
    dpll_satisfiable
    WalkSAT
    SATplan
    unify
sofmonk changed the title added exmples to notebooks LOGIC & PLANNING added examples to notebooks LOGIC & PLANNING Mar 27, 2017

Copy link
Copy Markdown
Collaborator

I will paste some of my feedback from my previous comment so that it doesn't get lost.

  • Spacing issues. You have inconsistent spacing in the text. For example, you write "precondition(positive and negative)" and "same way as before :". In the first case you need a space before the parenthesis, while in the second case you need to remove the space before the colon.

  • Capitalization issues. When starting a new sentence, you should be using capital letters even if before that you had a code example. It still is a sentence + you break capitalization consistency.

  • Formatting/Styling. Most of the Notebooks utilize formatting to help ease the reader in. Italics, bold, etc. help a lot and look nice. A lot of the time I was not sure if what I was reading was an actual word or a function/class name. This can be easily fixed by styling function/variable/etc names as code. You can do that by wrapping the name in left-leaning quotations (the quotation usually found under the 'tilde' key -> ``). It produces more or less the following effect: code. You can use italics and bold font in similar instances too.


Like before, the notebooks you provided are lacking in description. While you did improve this since last time, there is still a lot missing. The majority of the examples you provide are not adequately explained and leave a lot up to the reader. I'm not saying explain every little detail, but you need to write a bit more.

As an example take the following:

KB.tell(A & C)
KB.ask(A) == KB.ask(C) == {}

You write the above code and the explanation you write is this: "adds sentence and checks if KB entails the query."

This brings up a lot of questions: Is "A & C" the sentence? What does "KB.ask(A)" do? Why does it return an empty dictionary? What exactly is "A"?

All these questions can be easily answered by a couple of sentences.


This is definitely an improvement from last time and you are on the right track, but in my opinion this still needs work before it gets merged.

Again, this is ultimately up to @norvig, but I would take quality and thoroughness over quantity.

sofmonk added 2 commits March 28, 2017 23:20
added factored state representation, assumptions, dock worker robot domain.

Copy link
Copy Markdown
Collaborator

I like these additions. Very nice work.

Did you make the images yourself?

sofmonk commented Mar 29, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@MrDupin Thank you, your feedback helped out.
I got those images from other websites. I am still doubtful if we can use other web-site's content?

Copy link
Copy Markdown
Collaborator

That depends, but maybe not. If you share where you found them I can look into this more.

Chipe1 commented Mar 29, 2017

Copy link
Copy Markdown
Contributor

@sofmonk That depends. In most cases you are not allowed to reuse the images without permission. It would be better if we used images in the textbook or make them on our own.
I would recommend opening an issue and posting what images are needed. Me and other contributors can create the required images and upload them.

sofmonk mentioned this pull request Mar 31, 2017
Comment thread logic.ipynb
"| Implication | P &rarr; Q | `P` <tt>&#124;</tt>`'==>'`<tt>&#124;</tt> `Q` | `P ==> Q` | `Expr('==>', P, Q)`\n",
"| Reverse Implication | Q &larr; P | `Q` <tt>&#124;</tt>`'<=='`<tt>&#124;</tt> `P` |`Q <== P` | `Expr('<==', Q, P)`\n",
"| Equivalence | P &harr; Q | `P` <tt>&#124;</tt>`'<=>'`<tt>&#124;</tt> `Q` |`P <=> Q` | `Expr('<=>', P, Q)`\n",
"| Equivalence | P &harr; Q | `P` <tt>&#124;</tt>`'<=>'`<tt>&#124;</tt> `Q` |`P ==> Q` | `Expr('==>', P, Q)`\n",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Similar to #421, there are some changes that revert #361. Make sure you update your local repo to the latest version.

sofmonk closed this Apr 13, 2017
sofmonk reopened this Apr 13, 2017
sofmonk mentioned this pull request Apr 18, 2017

norvig commented May 28, 2017

Copy link
Copy Markdown
Member

This is good, I appreciate the work on this! But we need to resolve some issues -- the branch has conflicts, the rights to the photos have to be figured out (we need to get permission to the author (or the author has to state a license agreement like creative commons) and we have to give credit to the original author. And there are a few comments from MrDupin should be addressed.

norvig closed this Mar 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL