Viterbi Calculation Reusability + Comment Fixes - #429
Closed
antmarakis wants to merge 1 commit into
Closed
antmarakis wants to merge 1 commit into
antmarakis wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
antmarakis
commented
Apr 2, 2017
Comment thread
text.py
| w = text[j:i] | ||
| if P[w] * best[i - len(w)] >= best[i]: | ||
| best[i] = P[w] * best[i - len(w)] | ||
| curr_score = P[w] * best[i - len(w)] |
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
I have seen curr_something (or currSomething etc.) pop up a lot around, so I assume most people will get it. The problem with p_score is that p doesn't give enough information, which is not the same case as curr_score.
I personally feel it's fine, but I don't feel strongly about it. If more have the same issue, I will change it.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
You are right. I'm sure most won't have an issue.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Branch was deleted, will make a new PR. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In viterbi_segment, the calculation P[w] * best[i - len(w)] is used twice in a row, so I stored it into a variable (curr_score) and used that instead.
Also made quotation and spacing fixes to the comments.