FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Implemented HybridWumpusAgent by kunwar31 · Pull Request #842 · aimacode/aima-python · GitHub

Repository navigation

Implemented HybridWumpusAgent - #842

Merged
norvig merged 2 commits into
aimacode:masterfrom
kunwar31:master
Mar 15, 2018
Merged

norvig merged 2 commits into
aimacode:masterfrom
kunwar31:master

Conversation

Copy link
Copy Markdown
Contributor

Solves part of #641 ( implement HybridWumpusAgent ) and therefore part of #817

ghost commented Mar 13, 2018

Copy link
Copy Markdown
Contributor

Nice work! Are you going to complete the HybridWumpusAgent class too?

ghost commented Mar 13, 2018

Copy link
Copy Markdown
Contributor Author

Yes, I'm going to do that soon, within 1-2 days maximum.

ghost commented Mar 13, 2018

Copy link
Copy Markdown
Contributor

Great!

ghost commented Mar 13, 2018

Copy link
Copy Markdown
Contributor Author

Thanks @ad71

added WumpusPosition helping class.
kunwar31 changed the title Added WumpusKB for use in HybridWumpusAgent Implemented HybridWumpusAgent Mar 14, 2018

ghost commented Mar 14, 2018

Copy link
Copy Markdown
Contributor Author

@ad71 I've implemented HybridWumpusAgent class, left with plan_route() and plan_shot() helper functions

ghost commented Mar 14, 2018

Copy link
Copy Markdown
Contributor

Nice work! After you complete the remaining functions, make sure you add a few simple tests to see if everything works as intended.

ghost commented Mar 15, 2018

Copy link
Copy Markdown
Member

Looks good. I think a lot more could be done with Expr objects rather than string concatenation. That is, rather than "FacingEast(" + str(t) + ")" you could just have FacingEast(t) if you have already defined FacingEast as an Expr function.

norvig merged commit 49adcdb into aimacode:master Mar 15, 2018

ghost commented Mar 15, 2018

Copy link
Copy Markdown
Contributor Author

@norvig Thanks for the suggestion. I will try to refactor it.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL