Fixed planning notebook - #944
Closed
ad71 wants to merge 1 commit into
Closed
ad71 wants to merge 1 commit into
ad71 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@ad71 : To my best of knowledge no code was overwritten, only extended and fixed in certain places. The author of #973 is using the most recent version of master for each branch that she creates. However there were at the time a number of PR's that haven't been merged yet and naturally these will not be present in her master fork. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@delaray I had no idea that Dr. Norvig had decided to separate the notebooks. In that case, everything seems fine. I'll close this PR after I check the diffs once again. Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote notebook sections for GraphPlan, TotalOrderPlanner, PartialOrderPlanner, double_tennis_problem and job_shop_problem in PR #927 .
But the whole notebook was reverted back to an older version by #943 and replaced by a lot of other notebooks containing parts of the original notebook. This, I think was completely unnecessary as we are trying to maintain one notebook per chapter and moreover, a lot of the work I did on the planning notebook was removed and overwritten. This happened because the author of #943 used an outdated fork of the repository.
Here is a new PR that fixes these problems and also incorporates the notebook sections for angelic_search and hierarchical_search.