Allow you to handle your marker click event - #136
Merged
nwadams merged 5 commits intoJul 18, 2019
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
nwadams
approved these changes
Jul 17, 2019
ngsilverman
reviewed
Jul 17, 2019
ngsilverman
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
If you follow my suggestion then I think this change makes sense, even if it is breaking. Make sure to add documentation to the interface you're modifying though.
Sorry, something went wrong.
Comment thread
library/src/main/java/com/airbnb/android/airmapview/NativeGoogleMapFragment.java
Outdated
| listener.onMapMarkerClick(airMarker); | ||
| } | ||
| return false; | ||
| return listener.onMakerClickEventIsHandled(); |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Why not add a return value to onMapMarkerClick instead? Seems more idiomatic.
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
I pushed a change that addressed this comment
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows adds an option for users to handle onMarkerClick() event, so that the default behavior should not occur. The default behavior is for the camera to move to the marker once it's clicked. (https://developers.google.com/android/reference/com/google/android/gms/maps/GoogleMap.OnMarkerClickListener). This is a breaking change because it requires people who uses this library to implement onMarkerClickEventIsHandled()
I'm making a change for Explore Map to disable the behavior where the map centers on a marker once it's clicked. This is how this change looks on the demo map. Note that the map doesn't center on the markers when I click them.