FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed some dead links in the resource section of readme by Yash-Ambekar · Pull Request #2852 · airbnb/javascript · GitHub

/ javascript Public

Fixed some dead links in the resource section of readme - #2852

Draft
Yash-Ambekar wants to merge 3 commits into
airbnb:masterfrom
Yash-Ambekar:readmeDeadLinks
ConversationCommits (3)ChecksFiles changed
Draft

Fixed some dead links in the resource section of readme#2852
Yash-Ambekar wants to merge 3 commits into
airbnb:masterfrom
Yash-Ambekar:readmeDeadLinks

Conversation

Yash-Ambekar commented Oct 15, 2023

Copy link
Copy Markdown

Fixed some dead links in the resource section of ReadMe when I was going through some of the linked resources.

matheusfelipeog reviewed Oct 16, 2023
View reviewed changes
Comment thread README.md Outdated
ljharb reviewed Oct 16, 2023
View reviewed changes
Comment thread README.md Outdated
**Podcasts**

- [JavaScript Air](https://javascriptair.com/)
- [JavaScript Air](http://audio.javascriptair.com/)

ljharb Oct 16, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

is this not available using https?

ljharb Oct 23, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Yash-Ambekar you marked this as resolved, but it's not resolved. can you answer the question?

Yash-Ambekar commented Oct 23, 2023

Copy link
Copy Markdown
Author

@ljharb @matheusfelipeog please review my changes and guide me how can I improve upon the changes.

ljharb reopened this Oct 28, 2023

cclypeatus commented Dec 13, 2023

Copy link
Copy Markdown

The original link gives me a 502 Bad Gateway, while the new HTTP link gets blocked on Firefox in HTTPS only mode. One of these links might be a better replacement:

ljharb marked this pull request as draft December 13, 2023 18:21

Yash-Ambekar commented Dec 14, 2023

Copy link
Copy Markdown
Author

The original link gives me a 502 Bad Gateway, while the new HTTP link gets blocked on Firefox in HTTPS only mode. One of these links might be a better replacement:

Yeah providing web archive links seems like a good idea to me. @ljharb please can you give your opinion on this.

ljharb commented Dec 14, 2023

Copy link
Copy Markdown
Collaborator

I'm fine with an archive.org link for any links that are dead; if we also want to reference a new URL that seems to have the same content, that's fine too.

Yash-Ambekar requested a review from ljharb December 17, 2023 07:53
ljharb reviewed Dec 17, 2023
View reviewed changes
Comment thread README.md
- [Latest ECMA spec](https://tc39.github.io/ecma262/)
- [ExploringJS](https://exploringjs.com/)
- [ES6 Compatibility Table](https://compat-table.github.io/compat-table/es6/)
- [ES6 Compatibility Table](https://kangax.github.io/compat-table/es6/)

ljharb Dec 17, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this should be reverted, the compat table lives in an org now

anandfresh suggested changes Sep 29, 2024
View reviewed changes
Comment thread README.md
**Podcasts**

- [JavaScript Air](https://javascriptair.com/)
- [JavaScript Air](https://web.archive.org/web/20190626004622/https://javascriptair.com/)

anandfresh Sep 29, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Both the links point to the same source , so why this url change required ?

ljharb Sep 29, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like the website was down before, but is back up now.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ljharb ljharb left review comments
+3 more reviewers
matheusfelipeog matheusfelipeog left review comments
anandfresh anandfresh requested changes
Nyaundi Nyaundi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL