FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat!: use ecmaVersion latest by aladdin-add · Pull Request #2965 · airbnb/javascript · GitHub

feat!: use ecmaVersion latest - #2965

Draft
aladdin-add wants to merge 1 commit into
airbnb:masterfrom
aladdin-add:patch-2
Draft

feat!: use ecmaVersion latest#2965
aladdin-add wants to merge 1 commit into
airbnb:masterfrom
aladdin-add:patch-2

Conversation

aladdin-add commented Apr 10, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

The following code is often used when using @eslint/eslintrc with eslint-config-airbnb-base:

// mimic CommonJS variables -- not needed if using CommonJS
const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: pluginJs.configs.recommended});

However, import.meta is not supported in ecmaVersion: '2018'. This change allows users to be able to use it that way.

The following code is often used when using @eslint/eslintrc with `eslint-config-airbnb-base`:

```js
// mimic CommonJS variables -- not needed if using CommonJS
const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: pluginJs.configs.recommended});
```

However, `import.meta` is not supported in ecmaVersion: '2018'. This change allows users to be able to use it that way.

Copy link
Copy Markdown
Contributor Author

related: eslint/create-config#51

].map(require.resolve),
parserOptions: {
ecmaVersion: 2018,
ecmaVersion: 'latest',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this is a change we can't make unless babel-preset-airbnb is handling it by default. unfortunately i no longer maintain it, so I'm not familiar with what the latest version supports.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

seems it's no longer actively maintained - the last version was released ~4 years ago.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

accurate. but this is airbnb's eslint config, so my hands are kind of tied :-/

ljharb marked this pull request as draft August 23, 2024 17:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL