FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

UPDATE: Readme file update with specificity,Responsiveness and common pitfalls by Sandhya-Madhuri · Pull Request #3053 · airbnb/javascript · GitHub

UPDATE: Readme file update with specificity,Responsiveness and common pitfalls - #3053

Draft
Sandhya-Madhuri wants to merge 1 commit into
airbnb:masterfrom
Sandhya-Madhuri:update-readme
Draft

UPDATE: Readme file update with specificity,Responsiveness and common pitfalls#3053
Sandhya-Madhuri wants to merge 1 commit into
airbnb:masterfrom
Sandhya-Madhuri:update-readme

Conversation

Sandhya-Madhuri commented Oct 13, 2024
edited
Loading

Copy link
Copy Markdown

No description provided.

Sandhya-Madhuri changed the title UPDATE: Readme file update with specificity,Responsiveness and Common… UPDATE: Readme file update with specificity,Responsiveness and common pitfalls Oct 13, 2024
button: {
color: "red",
},
specialButton: {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

why is this an improvement? .specialButton targets a class, and specialButton targets a nonexistent tag name. did you mean 'button.specialButton'?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

specialButton in the second is just a property to styles. It is not a class we pass it using styles.specialButton. It is a css-in-js syntax

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

can you elaborate? I’m not familiar with any css-in-js solution that conflates tag names and class names in this way.

button: {
color: "red",
},
specialButton: {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
specialButton: {
'button.specialButton': {

Comment on lines +582 to +585
buttonActive: {
color: "green",
},
buttonInactive: {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

again, should these be class names?

This comment was marked as spam.

This comment was marked as resolved.

ljharb marked this pull request as draft October 14, 2024 21:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL