| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
👍 |
Sorry, something went wrong.
|
This relates to #612. What is your rationale for not putting each component in its own module? |
Sorry, something went wrong.
|
Mostly it's because the stateless functions makes it really easy to have lots of really tiny components, that might not be reusable. Having them in their own files seems overkill when they are only used in a single place. As we use CSS Modules as well, that'd mean an extra stylus file in addition, for something that might be 3 lines of code. |
Sorry, something went wrong.
|
That seems reasonable to me. Let's get some more consensus (which might take a week or so, due to holidays) before proceeding. |
Sorry, something went wrong.
|
👍 but we don't use stateless components yet so 😐 |
Sorry, something went wrong.
|
Sounds like this is OK to merge, it just won't do us any good at Airbnb just yet :-) @SimenB can you rebase this freshly on top of latest master, and also add a note to this effect in the react styleguide? |
Sorry, something went wrong.
|
Will do later today! |
Sorry, something went wrong.
|
@ljharb Updated. I don't know what text you actually want though. Is this fine? |
Sorry, something went wrong.
|
This looks great! perhaps a link inline to the eslint rule docs? |
Sorry, something went wrong.
|
Like so? |
Sorry, something went wrong.
[eslint config] [minor] Allow multiple stateless components in a single file
| Back | FazBrowse Home | New Git URL |
IDK if you want it, but we had linting errors after upgrading eslint-plugin-react.
This change allows multiple stateless components in a single file.
Requires 3.80 of eslint-plugin-react
https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md#380---2015-11-07