連想配列の追加 - #693
Closed
FineArchs wants to merge 10 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
FineArchs
marked this pull request as ready for review
June 21, 2024 11:48
FineArchs
requested review from
ikasoba,
kakkokari-gtyih,
marihachi,
salano-ym,
syuilo and
uzmoi
June 21, 2024 11:48
salano-ym
approved these changes
Jul 5, 2024
FineArchs
requested review from
ikasoba,
kakkokari-gtyih,
marihachi,
syuilo and
uzmoi
and removed request for
ikasoba,
kakkokari-gtyih,
marihachi,
syuilo and
uzmoi
July 10, 2024 09:41
marihachi
reviewed
Jul 13, 2024
marihachi
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
キーを[]で囲むというのは方針として決まってるものですか？
先にissueの方で提案お願いします
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
#225内のikasobaさんの案を部分的に採用したものになります。（文字列のキーのより簡潔な表記法については一旦後回しにしています） 方針として確定している訳ではないので、問題提起があれば再検討したいと思います。 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
名前空間記法との兼ね合いから、キーは全て[ ]で囲うようになっています。
キーの等価性はdeep-equalになっています（関数のみ参照比較）。
実装
トライ木の構造を採用しています。
その都合上、キーを直列化する仕組みを導入しています。
Why
#225
備考