Two minor fixes to error handling - #14
Open
mindplay-dk wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
1. You can't actually test for existence of `console` in global scope by just doing `if (console)` - this would error. I've corrected it to test with `typeof console !== "undefined"` which won't error in the absence of `console`. 2. Accessing global `console` and writing to the log is an uncontrollable side-effect that creates problems for me, as I'm actually using the console to output JSON data. To avoid a breaking change, I've kept this behavior, but made it optional: you can now supply an optional `onError` callback instead, overriding the backwards-compatible default behavior of writing to the console.
Copy link
Copy Markdown
Author
|
@albell is this project maintained? Looks like no releases since 2016 - but also no open issues, so that could just mean it's done and the spec hasn't changed. We can't have side-effects in our project - so if this project is unmaintained (or for some reason you don't want to merge this change) we may need to fork the package. |
Sorry, something went wrong.
valerio-so
approved these changes
Apr 1, 2023
valerio-so
approved these changes
Apr 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can't actually test for existence of console in global scope by just doing if (console) - this would error. I've corrected it to test with typeof console !== "undefined" which won't error in the absence of console.
Accessing global console and writing to the log is an uncontrollable side-effect that creates problems for me, as I'm actually using the console to output JSON data. To avoid a breaking change, I've kept this behavior, but made it optional: you can now supply an optional onError callback instead, overriding the backwards-compatible default behavior of writing to the console.