| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Failed to retrieve llama text: Invalid URL '/completion': No scheme supplied. Perhaps you meant https:///completion? |
Sorry, something went wrong.
Bumps [eth-typing](https://github.com/ethereum/eth-typing) from 4.3.1 to 5.2.0. - [Changelog](https://github.com/ethereum/eth-typing/blob/main/docs/release_notes.rst) - [Commits](ethereum/eth-typing@v4.3.1...v5.2.0) --- updated-dependencies: - dependency-name: eth-typing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
This is a straightforward dependency bump of eth-typing from 4.3.1 to 5.2.0. Although this is a major version bump with breaking changes (notably replacing ABIFunctionInfo with ABIElementInfo and ABI component type changes in v5.0.0-beta.3/v5.0.1), the codebase only uses HexStr from eth_typing, which is unaffected by these changes. The update is safe. One minor pre-existing concern is that the dependency is pinned with == (exact version) rather than a compatible range like >=4.3.1,<6, which could create unnecessary friction for downstream consumers — but that's a pre-existing style issue, not introduced by this PR.
pyproject.toml (line 39): Pre-existing nit (not introduced by this PR): eth-typing==5.2.0 uses an exact pin. For a library, a range like >=5.2.0,<6 would be more flexible for downstream consumers without sacrificing compatibility guarantees. Worth addressing as a follow-up.
Sorry, something went wrong.
There was a problem hiding this comment.
This is a straightforward major version bump of eth-typing from 4.3.1 to 5.2.0. The project's only usage of eth-typing is importing HexStr in src/aleph/sdk/wallets/ledger/ethereum.py, which is a stable primitive type unchanged across versions. The v5.x breaking changes (e.g., ABIFunctionInfo → ABIElementInfo, ABI type cleanup) are not used anywhere in the codebase. The change preserves the project's existing pattern of exact-version pinning for this dependency.
Sorry, something went wrong.
There was a problem hiding this comment.
This is a straightforward major version bump of eth-typing from 4.3.1 to 5.2.0. The only usage in the codebase is from eth_typing import HexStr in src/aleph/sdk/wallets/ledger/ethereum.py, and HexStr is a stable primitive type unaffected by the breaking changes in 5.x (which focused on ABI types like ABIFunctionInfo → ABIElementInfo). The change is safe. One minor note about potential transitive compatibility with web3==6.3 is worth verifying, but not a blocker.
pyproject.toml (line 39): Worth verifying that web3==6.3 (also pinned in this file) is compatible with eth-typing==5.2.0. web3 6.3 was released before eth-typing 5.0 (Aug 2024), so it may declare a eth-typing<5 upper bound in its own dependencies. If so, this combination would fail to install. Running pip check or inspecting web3 6.3's declared dependency range for eth-typing would confirm compatibility.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Bumps eth-typing from 4.3.1 to 5.2.0.
ChangelogSourced from eth-typing's changelog.
... (truncated)
CommitsYou can trigger a rebase of this PR by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: