FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adding C# to the build system (using the Mono toolchain) by Amaras · Pull Request #1012 · algorithm-archivists/algorithm-archive · GitHub

/ algorithm-archive Public

Adding C# to the build system (using the Mono toolchain) - #1012

Merged
ShadowMitia merged 6 commits into
algorithm-archivists:mainfrom
Amaras:scons_csharp
Aug 23, 2023
ConversationCommits (6)ChecksFiles changed
Merged

Adding C# to the build system (using the Mono toolchain)#1012
ShadowMitia merged 6 commits into
algorithm-archivists:mainfrom
Amaras:scons_csharp

Conversation

Amaras commented Aug 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This is a PR to add C# to our build system, making sure we have a common ground.
I see we have the dotnet sdk, but I could not find the command to compile using it, don't hesitate to close this PR if you give me the proper way.

Because I used Mono, there were a few changes in two files, as Mono doesn't allow functions inside functions, apparently.

This follows from #1011, but might need to be merged before.

Amaras added lang: c# C# programming language SCons For SCons-related matters labels Aug 20, 2023
This was referenced Aug 20, 2023
Open
Open

Amaras commented Aug 20, 2023

Copy link
Copy Markdown
Member Author

Right... @ntindle or @ShadowMitia, do I need to separate the Docker stuff from the SCons stuff for the build to pass?

ntindle commented Aug 20, 2023

Copy link
Copy Markdown
Member

Docker should probably go in first. I can't remember the exact repo ci we used but if we did it right, it won't use the dockerfile you provide here but the one on the base branch

ShadowMitia commented Aug 20, 2023

Copy link
Copy Markdown
Contributor

FYI: for dotnet you can use this as reference: SebLague/Chess-Challenge#3
But it could be good to support both? I don't really know C# ecosystem well enough.
I don't have an opinion on which one is better to use.

Amaras commented Aug 22, 2023

Copy link
Copy Markdown
Member Author

There we go, everything builds :)
If someone wants to review it, please do so we can move on

ShadowMitia approved these changes Aug 23, 2023
View reviewed changes

ShadowMitia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ShadowMitia merged commit 59c0b9d into algorithm-archivists:main Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ShadowMitia ShadowMitia approved these changes

Assignees

No one assigned

Labels

lang: c# C# programming language SCons For SCons-related matters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL