FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

perf: Simplify Vega transforms for coverage base counts by fxwiegand · Pull Request #407 · alignoth/alignoth · GitHub

perf: Simplify Vega transforms for coverage base counts - #407

Merged
fxwiegand merged 1 commit into
mainfrom
improved-transform
Nov 14, 2025
Merged

fxwiegand merged 1 commit into
mainfrom
improved-transform

Conversation

Copy link
Copy Markdown
Collaborator

This pull request refactors the transformation logic in the resources/plot.vl.json file to simplify and optimize how base counts (a, t, g, c) are extracted and calculated. The previous approach used multiple split, flatten, and aggregate operations for each base type, which has now been replaced with a more concise method that uses index searching and direct calculation. This should make the transformation pipeline easier to maintain and potentially improve performance.

Refactoring and simplification of transformation logic:

  • Removed multiple split, flatten, and aggregate steps for extracting and aggregating base counts (a, t, g, c), reducing complexity in the transformation pipeline. [1] [2]
  • Introduced a new approach that calculates a search_key for each position, finds the index of each base type in its respective string, and directly extracts the count using conditional logic and string slicing.

fxwiegand merged commit 7d094d5 into main Nov 14, 2025
6 checks passed
fxwiegand deleted the improved-transform branch November 14, 2025 09:30

Copy link
Copy Markdown

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.34%. Comparing base (5276e21) to head (d863d90).
⚠️ Report is 1 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #407   +/-   ##
=======================================
  Coverage   49.34%   49.34%           
=======================================
  Files           6        6           
  Lines         685      685           
=======================================
  Hits          338      338           
  Misses        347      347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL