Currently, when \contributorsSortAlphabetically: true\ is configured, sorting is performed directly on \�.name\ using default \localeCompare. This leads to:
Capitalized names (A-Z) and lowercase names (a-z) sorting into separate clusters rather than a natural, case-insensitive alphabetical sequence.
Contributor records that lack an explicit
ame\ property sorting incorrectly as empty strings instead of falling back to their \login.
Changes Made
Updated \generateContributorsList\ in src/generate/index.js to sort with \localeCompare(..., undefined, { sensitivity: 'base' })\ with fallback to standard \localeCompare.
Added fallback to contributor \login\ when
ame\ is not present, matching the display fallback in src/generate/format-contributor.js.
Added comprehensive unit tests in src/generate/tests/index.js validating case-insensitive sorting and missing name fallbacks.
Updated path assertions in src/util/tests/git.js to ensure cross-platform compatibility across Windows, macOS, and Linux.
Testing
Ran
pm test\ with 100% tests passing (15 test files, 116 tests).
Verified ESLint and Prettier formatting checks passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #370
Currently, when \contributorsSortAlphabetically: true\ is configured, sorting is performed directly on \�.name\ using default \localeCompare. This leads to:
ame\ property sorting incorrectly as empty strings instead of falling back to their \login.
Changes Made
ame\ is not present, matching the display fallback in src/generate/format-contributor.js.
Testing
pm test\ with 100% tests passing (15 test files, 116 tests).