Support Dynamic.link and Dynamic.description for allure-behave by oatssss · Pull Request #574 · allure-framework/allure-python · GitHub

Context

Hardcoded link tags in .features don't allow for dynamically adding links to the report. The dynamic use-case can be addressed with allure.dynamic.link(), however it appears to be a no-op for allure-behave. This PR adds the missing add_link hook to the behave listener.

With these changes, in addition to:

@allure.issue:https://jira.example.com/JIRA-1234
Scenario: Scenario with passed step
    Given simple passed step

we can also do:

import allure

def before_scenario(context, scenario):
    allure.dynamic.issue("https://jira.example.com/JIRA-1234", "JIRA-1234")

I used the pytest implementation as a reference for these changes:

allure-python/allure-pytest/src/listener.py

Lines 246 to 256 in c217262

    
           @allure_commons.hookimpl 
        
           def add_link(self, url, link_type, name): 
        
               test_result = self.allure_logger.get_test(None) 
        
               if test_result: 
        
                   pattern = dict(self.config.option.allure_link_pattern).get(link_type, u'{}') 
        
                   link_url = pattern.format(url) 
        
                   new_link = Link(link_type, link_url, link_url if name is None else name) 
        
                   for link in test_result.links: 
        
                       if link.url == new_link.url: 
        
                           return 
        
                   test_result.links.append(new_link)

Checklist

Sign Allure CLA
Provide unit tests

There are no changes to allure-robotframework I suspect the check-errors are not related to my changes.

…llure-framework#574)

oatssss added 7 commits March 18, 2021 14:10

Add Behave support for Dynamic.link

356ee65

Add test case for behave dynamic links

480970c

Double line is required

4c053cc

Meet line length requirements

f7e92c7

Fix PEP8 E128

e2d7d22

Implement dynamic descriptions in behave listener

a408c62

Add behave test case for dynamic description

2982a3e

oatssss force-pushed the master branch from c187d6a to 2982a3e Compare March 18, 2021 18:11

oatssss changed the title Support Dynamic.link for allure-behave Support Dynamic.link and Dynamic.description for allure-behave Mar 18, 2021

Merge branch 'master' into master

5b7b66b

sseliverstov approved these changes Mar 22, 2021

View reviewed changes

sseliverstov merged commit 61da8af into allure-framework:master Mar 22, 2021

beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023

support Dynamic.link and Dynamic.description for allure-behave (via a…

817e341

…llure-framework#574)

IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024

support Dynamic.link and Dynamic.description for allure-behave (via a…

eacefcc

…llure-framework#574)

Support Dynamic.link and Dynamic.description for allure-behave by oatssss · Pull Request #574 · allure-framework/allure-python · GitHub

Uh oh!

Support Dynamic.link and Dynamic.description for allure-behave - #574

Support Dynamic.link and Dynamic.description for allure-behave#574
sseliverstov merged 8 commits into
allure-framework:masterfrom
oatssss:master

oatssss commented Mar 17, 2021 •
edited
Loading

Uh oh!

Uh oh!

oatssss commented Mar 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	@allure_commons.hookimpl
	def add_link(self, url, link_type, name):
	test_result = self.allure_logger.get_test(None)
	if test_result:
	pattern = dict(self.config.option.allure_link_pattern).get(link_type, u'{}')
	link_url = pattern.format(url)
	new_link = Link(link_type, link_url, link_url if name is None else name)
	for link in test_result.links:
	if link.url == new_link.url:
	return
	test_result.links.append(new_link)

Support Dynamic.link and Dynamic.description for allure-behave by oatssss · Pull Request #574 · allure-framework/allure-python · GitHub

Uh oh!

Support Dynamic.link and Dynamic.description for allure-behave - #574

Support Dynamic.link and Dynamic.description for allure-behave#574sseliverstov merged 8 commits intoallure-framework:masterallure-framework/allure-python:masterfrom oatssss:masteroatssss/allure-python:masterCopy head branch name to clipboard

Conversation

oatssss commented Mar 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Checklist

Uh oh!

oatssss commented Mar 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Support Dynamic.link and Dynamic.description for allure-behave#574
sseliverstov merged 8 commits into
allure-framework:masterfrom
oatssss:master

oatssss commented Mar 17, 2021 •
edited
Loading