Fix redefined fixtures handling - #592
Merged
sseliverstov merged 2 commits intoMay 24, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
added 2 commits
May 24, 2021 09:38
Pytest allows to redefine fixture using results of execution of original fixture (see https://docs.pytest.org/en/stable/fixture.html#overriding-fixtures-on-various-levels for details) The previous implementation of fixture handling relied on str(fixturedef) which can be identical for both original and redefined fixtures. `fixturemanager.getfixturedefs(name, item.nodeid)` returns fixturedefs for both original and redefined fixture so we need to use all results of `fixturemanager.getfixturedefs` and not just the last element.
sseliverstov
approved these changes
May 24, 2021
beckerGil
pushed a commit
to beckerGil/allure-python
that referenced
this pull request
Apr 10, 2023
IvanBuruyane
pushed a commit
to IvanBuruyane/allure-python
that referenced
this pull request
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pytest allows to redefine fixture using results of execution of original fixture (see https://docs.pytest.org/en/stable/fixture.html#overriding-fixtures-on-various-levels for details)
The previous implementation of fixture handling relied on str(fixturedef) which can be identical for both original and redefined fixtures so we use python built-in id()
fixturemanager.getfixturedefs(name, item.nodeid) returns fixturedefs for both original and redefined fixture so we need to use all results of fixturemanager.getfixturedefs and not just the last element.
Checklist