Fix cache issue with the build workflow - #810
Merged
delatrie merged 1 commit intoApr 18, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
- remove build & cache of commons (install from dirs instead) - fix install packages command
skhomuti
approved these changes
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Starting from version 69.3.0, Setuptools canonicalizes filenames of a source distribution according to PEP 625. Notably, all hyphens (-) are replaced with underscores (_) in the distribution name.
That leads to the following error when installing previously built common packages during a testing job of the build workflow:
If we run ls dist before pip install, we see the following content:
Although a simple fix of the pip install command would be enough, I've decided to eliminate caching altogether and replace it with direct installation from the corresponding directory. The caching doesn't save us anything:
PS > python -m venv env && ./env/bin/Activate.ps1 && measure-command { pip install ./dist/allure_python_commons-2.13.6.dev1+gf185ccc.tar.gz } Days : 0 Hours : 0 Minutes : 0 Seconds : 11 Milliseconds : 705 Ticks : 117050592 TotalDays : 0.000135475222222222 TotalHours : 0.00325140533333333 TotalMinutes : 0.19508432 TotalSeconds : 11.7050592 TotalMilliseconds : 11705.0592 PS > rm -rf env && python -m venv env && ./env/bin/Activate.ps1 && measure-command { pip install ./allure-python-commons } Days : 0 Hours : 0 Minutes : 0 Seconds : 10 Milliseconds : 378 Ticks : 103782877 TotalDays : 0.000120119070601852 TotalHours : 0.00288285769444444 TotalMinutes : 0.172971461666667 TotalSeconds : 10.3782877 TotalMilliseconds : 10378.2877In fact, it only makes the build longer and more complicated.