chore(commons): tiny fixes of step type checking - #846
Merged
delatrie merged 2 commits intoMar 27, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
delatrie
force-pushed
the
step-typing-fixes
branch
from
668a490 to
51cf7ce
Compare
March 27, 2025 09:09
delatrie
force-pushed
the
step-typing-fixes
branch
from
51cf7ce to
6eb7010
Compare
March 27, 2025 09:14
baev
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
#830 introduces proper typing annotations for allure.step via @typing.overload.
This PR removes the annotations from the implementation as per the Python docs:
It also disables type checking of the wrapper function returned by StepContext.__call__ (it can't be typechecked without ParamSpec, which is only available in Python 3.10+).