FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Set the correct detail message for passed steps (fix #835) by sharovd · Pull Request #853 · allure-framework/allure-python · GitHub

/ allure-python Public

Set the correct detail message for passed steps (fix #835) - #853

Merged
delatrie merged 2 commits into
allure-framework:masterfrom
sharovd:fix-835-incorrect-details-message
Apr 24, 2025
ConversationCommits (2)ChecksFiles changed
Merged

Set the correct detail message for passed steps (fix #835)#853
delatrie merged 2 commits into
allure-framework:masterfrom
sharovd:fix-835-incorrect-details-message

Conversation

sharovd commented Apr 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Context

Report Robot Report Allure

Checklist

delatrie self-assigned this Apr 8, 2025
delatrie requested changes Apr 21, 2025
View reviewed changes

delatrie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi, @sharovd ! Thank you very much for contributing to allure-python.

I've checked the changes, and the code looks good to me. The only missing thing is a test that reproduces the issue. Could you pls add one?

If you need some guidance on how to test allure-robotframework, please let me know, and I will gladly help you.

delatrie linked an issue Apr 21, 2025 that may be closed by this pull request
allure_robotframework sets incorrect statusDetails message for steps #835
Closed

sharovd commented Apr 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi, @delatrie! Thanks for the review!
I've added the test test_only_failed_steps_have_status_details() that reproduces the problem described. I have verified that it fails on the master branch and passes with my changes.
The test follows the structure of the existing ones in the repository, but if you spot anything that could be improved, feel free to tell me.

delatrie approved these changes Apr 24, 2025
View reviewed changes

delatrie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good job!

delatrie merged commit 68bbafe into allure-framework:master Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

delatrie delatrie approved these changes

Assignees

delatrie

Labels

theme:robotframework type:enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allure_robotframework sets incorrect statusDetails message for steps

2 participants

Back | FazBrowse Home | New Git URL