FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Don't convert built-in (reserved) pytest markers to allure tags (fix #817) by sharovd · Pull Request #862 · allure-framework/allure-python · GitHub

/ allure-python Public

Don't convert built-in (reserved) pytest markers to allure tags (fix #817) - #862

Merged
delatrie merged 3 commits into
allure-framework:masterfrom
sharovd:fix-817-ignore-built-in-marks
Jun 9, 2025
ConversationCommits (3)ChecksFiles changed
Merged

Don't convert built-in (reserved) pytest markers to allure tags (fix #817)#862
delatrie merged 3 commits into
allure-framework:masterfrom
sharovd:fix-817-ignore-built-in-marks

Conversation

sharovd commented May 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Context

  • Fix the issue to prevent saving marks with parameters as labels → tag #817

  • Code changes:

    • The pytest_markers(item) method in utils.py has been simplified - now only "simple" user-defined pytest markers are converted to allure tags. Built-in (reserved) markers (e.g. skip, xfail, etc.) are now ignored. The approach was taken from allure-pytest-bdd implementation

  • Unit tests changes:

    • Existing tests in tag_test.py have been updated, new tests have been added for each built-in (reserved) marker to verify they are ignored
    • Renamed both the update and the new tests to make their purpose clearer
    • Removed test_pytest_marker_with_kwargs_native_encoding as a duplicate of test_pytest_marker_with_kwargs_utf_encoding - they looked identical
    • Updated the affected test in pytest_rerunfailures_test.py accordingly

Checklist

This was referenced May 17, 2025
Closed
Closed
delatrie self-requested a review May 20, 2025 10:48
delatrie requested changes Jun 9, 2025
View reviewed changes

delatrie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi, @sharovd ! Good job here!

Sorry for having kept you waiting for so long.

I would like to suggest a couple of tiny changes, please, check them out.

Comment thread tests/allure_pytest/acceptance/label/tag/tag_test.py Outdated
Comment thread tests/allure_pytest/acceptance/label/tag/tag_test.py Outdated
Comment thread tests/allure_pytest/acceptance/label/tag/tag_test.py Outdated
Comment thread tests/allure_pytest/acceptance/label/tag/tag_test.py Outdated
delatrie force-pushed the fix-817-ignore-built-in-marks branch from 3f3ba87 to c3b3197 Compare June 9, 2025 14:21
delatrie merged commit 4d67928 into allure-framework:master Jun 9, 2025
mshonichev mentioned this pull request Jul 15, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

delatrie delatrie approved these changes

Assignees

delatrie

Labels

theme:pytest type:enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL