FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixing category page 404 error due to exception message being passed as nil by kamalakannan-chockalingam · Pull Request #546 · allure-framework/allure-ruby · GitHub

/ allure-ruby Public

Fixing category page 404 error due to exception message being passed as nil - #546

Merged
andrcuns merged 2 commits into
allure-framework:masterfrom
kamalakannan-chockalingam:allure_404
Apr 16, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Fixing category page 404 error due to exception message being passed as nil#546
andrcuns merged 2 commits into
allure-framework:masterfrom
kamalakannan-chockalingam:allure_404

Conversation

kamalakannan-chockalingam commented Apr 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolving Issue: #544

CLAassistant commented Apr 16, 2024 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

kamalakannan-chockalingam mentioned this pull request Apr 16, 2024
Closed

qlty-cloud-legacy Bot commented Apr 16, 2024 •
edited
Loading

Copy link
Copy Markdown

Code Climate has analyzed commit 36b01cb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.9% (0.0% change).

View more on Code Climate.

andrcuns added the bug Something isn't working label Apr 16, 2024
andrcuns requested changes Apr 16, 2024
View reviewed changes

andrcuns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the fix. Minor suggestion for shorter code

Comment thread allure-ruby-commons/lib/allure_ruby_commons/result_utils.rb Outdated
andrcuns merged commit 4eb00e3 into allure-framework:master Apr 16, 2024

andrcuns commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator

Not sure if the java version has some additional handling, but looks like this introduced this NilClass to passed tests which isn't ideal.

andrcuns mentioned this pull request Apr 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

andrcuns andrcuns requested changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL