FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove uuid dependency by kpumuk · Pull Request #561 · allure-framework/allure-ruby · GitHub

/ allure-ruby Public

Remove uuid dependency - #561

Merged
andrcuns merged 1 commit into
allure-framework:masterfrom
kpumuk:uuid
Aug 20, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Remove uuid dependency#561
andrcuns merged 1 commit into
allure-framework:masterfrom
kpumuk:uuid

Conversation

kpumuk commented Aug 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why

The uuid gem is archived on GitHub since Jan 1, 2024: https://github.com/assaf/uuid

Although one might consider it feature complete and no longer require any updates (in fact, the last update was made 5 years ago), I would still consider it a risk. Its transitive dependencies macaddr and systemu were updated in 2019 and 2015 respectively.

The change removes 3 dependencies: uuid » macaddr » systemu.

How

Ruby already has a way to generate UUIDs via SecureRandom. It is v4 (compared to v1 implemented by the uuid gem), but for Allure purposes it should make no difference. Another option is PRNG version implemented in Random#uuid_v4 and Random#uuid_v7, but it requires an instance of PRNG, and so more code changes.

CLAassistant commented Aug 19, 2024 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

qlty-cloud-legacy Bot commented Aug 20, 2024

Copy link
Copy Markdown

Code Climate has analyzed commit 14e5af4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.9% (0.0% change).

View more on Code Climate.

kpumuk commented Aug 20, 2024

Copy link
Copy Markdown
Contributor Author

I probably can't do much about the CI failure

Your credentials were not found. To set up Application Default Credentials for your environment, see https://cloud.google.com/docs/authentication/external/set-up-adc

andrcuns commented Aug 20, 2024

Copy link
Copy Markdown
Collaborator

Makes perfect sense, less dependencies is always good 👍

CI failure is not critical, it couldn't upload the report, not a big deal.

andrcuns merged commit 7ccf409 into allure-framework:master Aug 20, 2024
andrcuns added the enhancement Improvement or request label Aug 20, 2024

kpumuk commented Aug 20, 2024

Copy link
Copy Markdown
Contributor Author

Thanks!

kpumuk deleted the uuid branch August 20, 2024 21:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement Improvement or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL