FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Style Attributes Content Handler by ggalileo · Pull Request #1076 · alohaeditor/Aloha-Editor · GitHub

Style Attributes Content Handler - #1076

Open
ggalileo wants to merge 2 commits into
alohaeditor:devfrom
ggalileo:ctct-style-attributes-content-handler
Open

ggalileo wants to merge 2 commits into
alohaeditor:devfrom
ggalileo:ctct-style-attributes-content-handler

Conversation

ggalileo commented Feb 6, 2014

Copy link
Copy Markdown
Contributor

This pull request is for a new common content handler that we have developed at Constant Contact.

The Style Attribute Content Handler will remove all unsupported style attribute items from all elements in the supplied content. The set of supported style attribute items is configured in the same manner as other content handler plugins via config in

Aloha.settings.contentHandler.handler.styleattribute.

This code has been tested across browsers by our QE and is used in our product.

  1. obey coding guidelines
  2. write JSLint compliant code
  3. write JSDoc for every method you touched during your implementation
  4. write a human-readable :) Changelog entry that describes your change
  5. add a qunit test (if it makes sense) and/or document the steps to manually test it (in a separate guides page)
  6. test your changes in Internet Explorer 7, 8, 9 and the latest Firefox and latest Chrome
  7. document your changes in a guides page
  8. include this list in a your pull request

Jotschi commented Feb 7, 2014

Copy link
Copy Markdown
Contributor

Request looks good.

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

Jotschi commented Feb 19, 2014

Copy link
Copy Markdown
Contributor

Admin please build this request

Copy link
Copy Markdown
Contributor

Test PASSed.
Refer to this link for build results: http://jenkins.office:8080/job/alohaeditor-upstream-pullrequests/17/

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

1 similar comment

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL