FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Generic Content Handler by ggalileo · Pull Request #1078 · alohaeditor/Aloha-Editor · GitHub

Generic Content Handler - #1078

Open
ggalileo wants to merge 2 commits into
alohaeditor:devfrom
ggalileo:ctct-generic-content-handler
Open

ggalileo wants to merge 2 commits into
alohaeditor:devfrom
ggalileo:ctct-generic-content-handler

Conversation

ggalileo commented Feb 6, 2014

Copy link
Copy Markdown
Contributor

This pull request enhances the generic content handler removeComments() function to remove comments that appear as text nodes in Firefox. This change also refactors the execution of the sub-handlers in the generic content handler to be configuration driven. Each sub-handler run by this content handler can be enabled or disabled via

Aloha.settings.contentHandler.handler.generic

This code has been tested across browsers by our QE.

  1. obey coding guidelines
  2. write JSLint compliant code
  3. write JSDoc for every method you touched during your implementation
  4. write a human-readable :) Changelog entry that describes your change
  5. add a qunit test (if it makes sense) and/or document the steps to manually test it (in a separate guides page)
  6. test your changes in Internet Explorer 7, 8, 9 and the latest Firefox and latest Chrome
  7. document your changes in a guides page
  8. include this list in a your pull request

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

Jotschi commented Feb 19, 2014

Copy link
Copy Markdown
Contributor

Admin please build this request

Copy link
Copy Markdown
Contributor

Test PASSed.
Refer to this link for build results: http://jenkins.office:8080/job/alohaeditor-upstream-pullrequests/16/

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

1 similar comment

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL