FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add support for PBXShellScriptBuildPhase by sundbry · Pull Request #107 · alunny/node-xcode · GitHub

/ node-xcode Public

Add support for PBXShellScriptBuildPhase - #107

Closed
sundbry wants to merge 4 commits into
alunny:masterfrom
sundbry:master
ConversationCommits (4)ChecksFiles changed
Closed

Add support for PBXShellScriptBuildPhase#107
sundbry wants to merge 4 commits into
alunny:masterfrom
sundbry:master

Conversation

sundbry commented Oct 26, 2016

Copy link
Copy Markdown
Contributor

This implements PBXShellScriptBuildPhase inside project.addBuildPhase.

Resolves issue #85 and upgrades version to 0.9.0

imhotep reviewed Oct 27, 2016
View reviewed changes
Comment thread lib/pbxProject.js
obj.dstSubfolderSpec = SUBFOLDERSPEC_BY_DESTINATION[DESTINATION_BY_TARGETTYPE[folderType]];
console.log("pbxCopyFilesBuildPhase");
console.log(obj);

imhotep Oct 27, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi, remove console.log()s and add unit tests please

sundbry commented Oct 27, 2016

Copy link
Copy Markdown
Contributor Author

@imhotep There we go. Lots of tests for this project. 👍

sundbry mentioned this pull request Oct 28, 2016
Merged

sundbry commented Oct 28, 2016

Copy link
Copy Markdown
Contributor Author

I opened a separate pr in #108 without the path name bugfix, to lower the risk of merging this all in.

sundbry closed this Oct 28, 2016

chrismowbraylit commented Feb 20, 2017 •
edited
Loading

Copy link
Copy Markdown

Hey @sundbry.

I added an isssue (#125) in relation to these changes. Would be great if there was a way to remove a build phase also.

sundbry commented Feb 20, 2017

Copy link
Copy Markdown
Contributor Author

@chrismowbray I can see why you'd want that, especially for making scripts idempotent etc. I can't promise I will get around to implementing it any time soon though.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

imhotep imhotep left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL