FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update Amazon SP API models to the latest version by jasonhebert · Pull Request #558 · amazon-php/sp-api-sdk · GitHub

/ sp-api-sdk Public

Update Amazon SP API models to the latest version - #558

Merged
norberttech merged 2 commits into
amazon-php:5.xfrom
scalecore:5.x-update_sp_api_models
Jan 24, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Update Amazon SP API models to the latest version#558
norberttech merged 2 commits into
amazon-php:5.xfrom
scalecore:5.x-update_sp_api_models

Conversation

jasonhebert commented Jan 23, 2024

Copy link
Copy Markdown
Contributor

Change Log

Added

Fixed

Changed

  • Add Jetbrains .idea directory to .gitignore.
  • Add user flag to Docker run commands in bin/generate.sh so files created are owned by the user/group running the operation.
  • Increase rector parallel processing timeout from 2 minutes to 10 minutes.
  • Update Amazon SP API models to the latest version

Removed

  • Remove Order Approvals API from SDK as it has been removed from the library.

Deprecated

Security

Description

  • Removed Order Approvals API from SDK as it has been removed from the library.
  • Added the Jetbrains IDE .idea meta directory to .gitignore.
  • Added the --user flag to the Docker run commands in bin/generate.sh so files created are owned by the user/group running the operation instead of the root user.
  • Increased the rector parallel processing timeout from 2 minutes to 10 minutes as timeout limit was reached during processing.

Update Amazon SP API models to the latest version
880eb1e 
Remove Order Approvals API from SDK as it has been removed from the library.
Add Jetbrains .idea directory to .gitignore.
Add user flag to Docker run commands in bin/generate.sh so files created are owned by the user/group running the operation.
Increase rector parallel processing timeout from 2 minutes to 10 minutes.
jasonhebert commented Jan 24, 2024
View reviewed changes
Comment thread src/AmazonPHP/SellingPartner/Api/ApprovalsApi/OrdersSDK.php

jasonhebert Jan 24, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Apparently this ItemApprovals portion of the specification (models/orders-api-model/ordersV0.json) was added on 01/25/2023 by Gibran Waldron and then reverted on 05/17/2023 by Jack Evoniuk. This is an unfortunate trend with Amazon developers and these API specifications.

norberttech Jan 24, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yeah, when I was working with their APIs I experienced things that nobody should experience. But honestly, in this case I believe we can keep it as is. I mean, yeah we can go with another major release but if it's was reverted then I’m assuming that this API stopped working anyway.
What are your thoughts?

jasonhebert Jan 24, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I personally would leave it on the 5.x branch and version it as such. I can make a notation in the changelog when the new version is tagged.

norberttech Jan 24, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

agreed 💪

norberttech reviewed Jan 24, 2024
View reviewed changes
Comment thread .gitignore Outdated
norberttech mentioned this pull request Jan 24, 2024
Closed
norberttech merged commit a0dd449 into amazon-php:5.x Jan 24, 2024
jasonhebert deleted the 5.x-update_sp_api_models branch January 31, 2024 17:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

norberttech norberttech left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL