FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added Rx1-Rx2 phase inversion enable enhancement to AD9361 system object. by SrikanthPagadarai · Pull Request #75 · analogdevicesinc/MathWorks_tools · GitHub

This repository was archived by the owner on Feb 2, 2021. It is now read-only.
/ MathWorks_tools Public archive

Added Rx1-Rx2 phase inversion enable enhancement to AD9361 system object. - #75

Open
SrikanthPagadarai wants to merge 2 commits into
masterfrom
AD9361_rx1rx2_phase_inversion
ConversationCommits (2)ChecksFiles changed
Open

Added Rx1-Rx2 phase inversion enable enhancement to AD9361 system object.#75
SrikanthPagadarai wants to merge 2 commits into
masterfrom
AD9361_rx1rx2_phase_inversion

Conversation

SrikanthPagadarai commented Aug 7, 2019

Copy link
Copy Markdown

No description provided.

tfcollins reviewed Aug 7, 2019
View reviewed changes
Comment thread +adi/+AD9361/Rx.m
isOutput = false;
end

properties (Hidden)

tfcollins Aug 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should be a logical

tfcollins Aug 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

And probably nontunable

Comment thread +adi/+AD9361/Rx.m

properties (Hidden)
%EnableRx1Rx2PhaseInversion
% If enabled, RX1 and RX2 are phase aligned

tfcollins Aug 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would recommend being more specific with this comment. Since it might give a wrong impression

Comment thread +adi/+AD9361/Rx.m
'', 'EnableRx1Rx2PhaseInversion');
obj.EnableRx1Rx2PhaseInversion = value;
if obj.ConnectedToDevice
obj.setDebugAttributeLongLong('adi,rx1-rx2-phase-inversion-enable',value);

tfcollins Aug 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Note that this won't actually update the part unless initialize is called

Comment thread +adi/+AD9361/Rx.m
obj.setDebugAttributeLongLong('loopback', obj.LoopbackMode);

% Enable Rx1-Rx2 Phase Inversion
obj.setDebugAttributeLongLong('adi,rx1-rx2-phase-inversion-enable', obj.EnableRx1Rx2PhaseInversion);

tfcollins Aug 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This won't do anything unless CustomAGC is enabled

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
tfcollins tfcollins left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL