Commit ccdcd91
benchmark: improve cli error message
When no matching benchmark files are found, a more sensible error
is shown now.
PR-URL: nodejs#12421
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 716d831 commit ccdcd91
2 files changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -88,6 +88,8 @@ CLI.prototype.benchmarks = function() { | |||
| 88 | 88 | const filter = this.optional.filter || false; | |
| 89 | 89 | ||
| 90 | 90 | for (const category of this.items) { | |
| 91 | + if (benchmarks[category] === undefined) | ||
| 92 | + continue; | ||
| 91 | 93 | for (const scripts of benchmarks[category]) { | |
| 92 | 94 | if (filter && scripts.lastIndexOf(filter) === -1) continue; | |
| 93 | 95 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -35,7 +35,7 @@ const runs = cli.optional.runs ? parseInt(cli.optional.runs, 10) : 30; | |||
| 35 | 35 | const benchmarks = cli.benchmarks(); | |
| 36 | 36 | ||
| 37 | 37 | if (benchmarks.length === 0) { | |
| 38 | - console.error('no benchmarks found'); | ||
| 38 | + console.error('No benchmarks found'); | ||
| 39 | 39 | process.exitCode = 1; | |
| 40 | 40 | return; | |
| 41 | 41 | } | |
0 commit comments