benchmark: improve cli error message - #12421
Closed
mscdex wants to merge 1 commit into
Closed
mscdex wants to merge 1 commit into
mscdex wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
joyeecheung
approved these changes
Apr 15, 2017
thefourtheye
approved these changes
Apr 15, 2017
aqrln
approved these changes
Apr 15, 2017
benjamingr
approved these changes
Apr 15, 2017
Comment thread
benchmark/_cli.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Maybe I'd add "in the current folder", but I don't run this often enough anyway.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
That would be confusing IMHO. The CLI searches all of the benchmark/ subdirectories for benchmarks specified on the command line. It never searches the current working directory.
Sorry, something went wrong.
cjihrig
approved these changes
Apr 15, 2017
jseijas
approved these changes
Apr 16, 2017
When no matching benchmark files are found, a more sensible error is shown now.
mscdex
force-pushed
the
benchmark-improve-error-message
branch
from
43926b1 to
3ca50a7
Compare
April 16, 2017 16:08
Copy link
Copy Markdown
Contributor
Author
|
I've tweaked this a bit after I discovered there is already a benchmark count check both in run.js and _cli.js. |
Sorry, something went wrong.
mscdex
commented
Apr 16, 2017
Comment thread
benchmark/compare.js
|
|
||
| if (benchmarks.length === 0) { | ||
| console.error('no benchmarks found'); | ||
| console.error('No benchmarks found'); |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
This matches the casing used in run.js.
Sorry, something went wrong.
jasnell
approved these changes
Apr 17, 2017
jasnell
pushed a commit
that referenced
this pull request
Apr 17, 2017
When no matching benchmark files are found, a more sensible error is shown now. PR-URL: #12421 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
When no matching benchmark files are found, a more sensible error is shown now. PR-URL: #12421 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
When no matching benchmark files are found, a more sensible error is shown now. PR-URL: #12421 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
When no matching benchmark files are found, a more sensible error is shown now. PR-URL: #12421 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
Marking as dont-land because this depends on #7094, which is semver-major. LMK if I'm wrong. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no matching benchmark files are found, a more sensible error is thrown now.
Checklist
Affected core subsystem(s)