Bump JetNews to alpha05 - #221
Merged
manuelvicnt merged 4 commits intoOct 14, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Changes: - Use new produceState API in launchUiStateProducer - Rename launchUiStateProducer to produceUiState to match naming - Change launchInComposition to new API LaunchedTask - Replace Box/Surface with new Box import - Update modifiers for Text composable to work with new layout rules - Update to use new AmbientContentColor and AmbientEmphasisLevels Bugfix: - Fix size of error case in [HomeScreenErrorAndContent], avoiding the swipe to refresh drawing in the incorrect place.
manuelvicnt
approved these changes
Oct 13, 2020
manuelvicnt
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Small nit but LGTM
Sorry, something went wrong.
Comment thread
JetNews/app/src/main/java/com/example/jetnews/ui/home/HomeScreen.kt
Outdated
manuelvicnt
approved these changes
Oct 14, 2020
Comment thread
JetNews/app/src/main/java/com/example/jetnews/ui/home/HomeScreen.kt
Outdated
manuelvicnt
added a commit
that referenced
this pull request
Oct 14, 2020
* [Jetcaster] Update to SNAPSHOT 6891475 (#216) * Update Jetcaster to SNAPSHOT 6891475 * Fix episode title being centered * [Crane] Update to SNAPSHOT 6891475 (#217) * [Jetchat] Update to SNAPSHOT 6891475 Change-Id: I4a9e194aabce890638da09a632de33928ad5237f * Spotless Change-Id: Ic46c8dcfd12451ff3988a1127ac97062b0b440fb * [Rally] Update to SNAPSHOT 6891475 Change-Id: I3252cfe051737927d76cc8559d24bf516a720d3c * [Jetsurvey] Bump to alpha05 * [Jetsurvey] Using onSizeChanged to set the branding height * [Jetsurvey] Bump to alpha05 * [Jetsurvey] Using onSizeChanged to set the branding height * [Rally] Removes maven central snapshot repo Change-Id: I473f1f55b40e4c81fc655568828db3ab94fea0a6 * [Jetchat] Removes maven central snapshot repo Change-Id: I5b16871c3ef1a612da8b6f1d96309f2bc40c19d3 * [Jetsnack] Update to snapshot 6901934. Change-Id: I1d6a951b9cba9994241315348daedaac1b5f278c * [Jetsnack] Remove unused import. Change-Id: Ieacdb2dc7253fe25977c123ee3d140b7bdb81f0d * [Owl] Accept modifiers in search suggestion items. Change-Id: I9a5bf25e5bfa4632738e1e03539039a9959a03f0 * [Owl] Update to snapshot 6901934. Change-Id: I15c92c5252e61b8918bbb9c80cbdc679e3809555 * Bump JetNews to alpha05 (#221) Changes: - Use new produceState API in launchUiStateProducer - Rename launchUiStateProducer to produceUiState to match naming - Change launchInComposition to new API LaunchedTask - Replace Box/Surface with new Box import - Update modifiers for Text composable to work with new layout rules - Update to use new AmbientContentColor and AmbientEmphasisLevels Bugfix: - Fix size of error case in [HomeScreenErrorAndContent], avoiding the swipe to refresh drawing in the incorrect place. * [Readme] Removes known issues (#222) * [All] Updates to alpha05 (#227) * [All] Updates to 6901934 snapshot * [All] Updates to alpha05 Co-authored-by: Chris Banes <chrisbanes@users.noreply.github.com> Co-authored-by: Jose Alcerreca <jalc@google.com> Co-authored-by: Florina Muntenescu <florinam@google.com> Co-authored-by: Florina Muntenescu <2998890+florina-muntenescu@users.noreply.github.com> Co-authored-by: Jose Alcérreca <JoseAlcerreca@users.noreply.github.com> Co-authored-by: Nick Butcher <nickbutcher@google.com> Co-authored-by: Nick Butcher <nickbutcher@users.noreply.github.com> Co-authored-by: Sean McQuillan <seanmcq@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Bugfix:
the swipe to refresh drawing in the incorrect place.