[Jetsurvey] Added take a photo feature - #279
Merged
florina-muntenescu merged 10 commits intoNov 10, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
florina-muntenescu
requested review from
chrisbanes,
manuelvicnt,
nickbutcher and
yrezgui
November 9, 2020 15:58
nickbutcher
reviewed
Nov 10, 2020
Comment thread
Jetsurvey/app/src/main/AndroidManifest.xml
Outdated
nickbutcher
reviewed
Nov 10, 2020
Comment thread
Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/survey/PhotoUriManager.kt
Outdated
nickbutcher
reviewed
Nov 10, 2020
Comment thread
Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/survey/PhotoUriManager.kt
Outdated
nickbutcher
reviewed
Nov 10, 2020
nickbutcher
reviewed
Nov 10, 2020
Comment thread
Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/survey/SurveyQuestions.kt
Outdated
nickbutcher
reviewed
Nov 10, 2020
Comment thread
Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/survey/PhotoUriManager.kt
Outdated
nickbutcher
reviewed
Nov 10, 2020
Comment thread
Jetsurvey/app/src/main/res/drawable/ic_selfie_dark.xml
Outdated
nickbutcher
reviewed
Nov 10, 2020
Comment thread
Jetsurvey/app/src/main/res/drawable/ic_selfie_light.xml
Outdated
nickbutcher
reviewed
Nov 10, 2020
nickbutcher
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Mostly LG, a few comments.
Sorry, something went wrong.
nickbutcher
reviewed
Nov 10, 2020
Comment thread
Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/survey/SurveyQuestions.kt
Outdated
chrisbanes
reviewed
Nov 10, 2020
Comment thread
Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/survey/SurveyScreen.kt
Outdated
Comment thread
Jetsurvey/app/src/main/AndroidManifest.xml
Outdated
yrezgui
requested changes
Nov 10, 2020
yrezgui
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Currently the app isn't working on devices running API 28 or less due to the WRITE_EXTERNAL_STORAGE permission. Check my comments on that
Sorry, something went wrong.
yrezgui
approved these changes
Nov 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showcasing launching intents and handling results.