[Owl] Migrates navigation to navigation-compose - #287
Merged
JoseAlcerreca merged 12 commits intoNov 24, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Change-Id: Ie5f550e3ea9eb6c8c3838358ad401794b6242314
Change-Id: Id41b29bc4174a694d1c1abee9fd37819912b54e8
Change-Id: I6fb4a08ee99b96438dc28d25b91abd32f9e0dbc6
Change-Id: I9c77838e006c8d6e45b62117daa7332d34754a4a
…tion_alpha07 Change-Id: I7f1eec345c23bd01fc3860ced23bf9f39f6e4713
Change-Id: I632f72c50f8ecf19f497fa126ec73ce1a1b64e94
Change-Id: I787b7863ccec5ff180630bb631740424e9a7e3f5
nickbutcher
reviewed
Nov 20, 2020
Comment thread
Owl/app/src/androidTest/java/com/example/owl/ui/NavigationTest.kt
Outdated
nickbutcher
reviewed
Nov 20, 2020
nickbutcher
reviewed
Nov 20, 2020
Comment thread
Owl/app/src/androidTest/java/com/example/owl/ui/fakes/ProvideTestImageLoader.kt
Outdated
nickbutcher
reviewed
Nov 20, 2020
Comment thread
Owl/app/src/main/AndroidManifest.xml
Outdated
nickbutcher
reviewed
Nov 20, 2020
Comment thread
Owl/app/src/main/java/com/example/owl/ui/NavGraph.kt
Outdated
nickbutcher
reviewed
Nov 20, 2020
Change-Id: Id15eb3775869d8914e49d73f5fbc66f05ba4e09c
Change-Id: I04c12559c2f1df2c2af5a143d9615ac47fbaa53b
Change-Id: I3ebf727b390b72c89ba3dd5be21e084347bc2840
nickbutcher
approved these changes
Nov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds new navigation tests
TODO: Bottom nav migration to navigation-compose