version catalog added; onBackPressed() replaced. - #96
Open
syslogic wants to merge 22 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
syslogic
commented
Sep 6, 2024
Comment thread
...yVault/app/src/main/java/com/example/android/authentication/myvault/ui/GetPasskeyActivity.kt
Outdated
Copy link
Copy Markdown
Author
|
com.google.android.gms.auth.api.credentials doesn't exist in later versions anymore, that's why module SmsVerification uses: google_play_services_auth = '20.5.0' |
Sorry, something went wrong.
… is not yet in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added version catalogs and updated most of the dependencies. It was unclear where the JSON string privilegedAllowlist comes from (in the MyVault app). Meanwhile I've found method getGPMPrivilegedAppAllowlist() and assume it should provide the desired JSON string.
There's another API change, which potentially breaks the SmsVerification app: It doesn't work with the latest play-services-auth dependency at version 21.2.0, that's why it's kept at version 20.5.0. I've also tried to add play-services-identity-credentials 16.0.0-alpha03, but it doesn't provide the missing classes. This library might be worth a new IdentityCredential example app.
Meanwhile method retrieveBytes() has been deprecated in BlockstoreClient while the Blockstore app doesn't have any fun retrieveBytes(bytesRequest: RetrieveBytesRequest) yet, which is supposed to replace it.