This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Updated project files and files of the modules (LocationUpdatesForegroundService and BasicLocationKotlin) - #243
Open
MadRatSRP wants to merge 15 commits into
Open
Updated project files and files of the modules (LocationUpdatesForegroundService and BasicLocationKotlin)#243MadRatSRP wants to merge 15 commits into
MadRatSRP wants to merge 15 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
-updated Android Gradle plugin to 4.0.1 -updated Gradle to 6.1.1 LocationUpdatesForegroundService: -updated Android Gradle plugin to 4.0.1 -reorganised dependencies and added "ext" block -updated AppCompat to 1.2.0 -updated Espresso to 3.3.0 -updated Junit to 4.13 -updated MaterialComponents to 1.2.1
-reorganised .gitignore file -enabled ViewBinding -MainActivity - refractored code for ViewBinding usage -added LocalBroadcastManager dependency -MainActivity - replaced BuildConfig.APPLICATION_ID for BuildConfig.LIBRARY_PACKAGE_NAME as BuildConfig.APPLICATION_ID became deprecated -updated imports
-reorganised LocalBroadcastManager in build.gradle -MainActivity - inverted checkPermissions method -set Java sourceCompatibility and targetCompatibility versions to 1.8 -refractored code for Java 1.8
-LocationUpdatesService - removed deprecated FusedLocationProviderApi in documentation and replaced it with FusedLocationProviderClient -LocationUpdatesService - replaced NotificationCompat.Builder constructor with non-deprecated one, refractored NotificationCompat.Builder initialization code -Added Jetpack Preference dependency -MainActivity and Utils classes - refractored to use Jetpack's PreferenceManager instead of deprecated one
-updated Gradle version to 6.1.1 -LocationUpdatesService - replaced deprecated Notification.PRIORITY_HIGH with NotificationCompat.PRIORITY_HIGH
-added android.useAndroidX=true to gradle.properties
-replaced remaining findViewById usages with ViewBinding LocationUpdatesForegroundServiceKotlin module: -initial commit
-replaced Jetpack Preference dependency with ktx version -Enabled Kotlin and Kotlin Gradle plugin in module's build.gradle files -ported module's files for Kotlin, started refractoring
-refractored LocationUpdatesService class -refractored MainActivity class
Copy link
Copy Markdown
Author
|
May I ask you a question, why are you not using this pull request if it is already passed tests? |
Sorry, something went wrong.
-Removed LocationUpdatesService.kt, re-added LocationUpdatesService.java, failed to properly convert it to Kotlin language -Utils: added @JvmStatic modifiers -MainActivity: small enhancements
-updated Android Gradle plugin dependency to 4.1.0 -updated Gradle dependency to 6.5 -settings.gradle - changed BasicLocationSample:java to BasicLocation and BasicLocationSample:kotlin to BasicLocationKotlin so these modules could be readed properly
-changed compileSdkVersion and targetSdkVersion to 30 -updated Android Gradle plugin dependency to 4.1.0 -updated Kotlin Gradle plugin and Kotlin JDK dependencies to 1.4.10 -reorganised dependencies -updated Jetpack AppCompat dependency to 1.2.0 -updated Jetpack MaterialComponents dependency to 1.2.1 -replaced Kotlin JDK7 dependency with Kotlin JDK8 -updated PlayServices Location dependency to 17.1.0 -enabled ViewBinding support in module's settings
-refactored MainActivity for using ViewBinding instead of findViewById and Java 8 features -replaced deprecated BuildConfig.APPLICATION_ID with BuildConfig.LIBRARY_PACKAGE_NAME -MainActivity: reorganised methods
Copy link
Copy Markdown
Author
|
Sorry, but when you'll be able to add these commits into main project? So this pull request could be closed. Its almost 4 months since I added this pull request and I dont see any feedback at all. So what's the problem? |
Sorry, something went wrong.
HoangTu2901
previously approved these changes
Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project:
-Updated Android Gradle plugin and Gradle versions
LocationUpdatesForegroundService:
-Updated Android Gradle plugin and Gradle versions
-Removed deprecated content (excepting this one #218)
-Partly refractored files
-Added android.useAndroidX=true to gradle.properties