Migrate JankStatsSample from Views to Jetpack Compose and Navigation3 - #362
Merged
AjeshRPai merged 3 commits intoAug 13, 2026
Merged
Migrate JankStatsSample from Views to Jetpack Compose and Navigation3#362AjeshRPai merged 3 commits into
AjeshRPai merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ion3 * Replace Fragment-based UI and Navigation Component with Jetpack Compose and Jetpack Navigation3. * Remove `MessageListFragment`, `MessageContentFragment`, `ComposeListFragment`, `MessageListAdapter`, and associated XML layout files and navigation graphs. * Add Jetpack Compose UI components (`MessageList`, `MessageContentScreen`, `JankStatsScaffold`) and Navigation3 components (`NavKeys`, `NavigationState`, `Navigator`). * Refactor `JankLoggingActivity` and `JankAggregatorActivity` to `ComponentActivity` using `setContent` with Compose UI and Lifecycle effects. * Bump `compileSdk` and `targetSdk` to 36, and `minSdk` to 23. * Add `navigation3` and `kotlinx-serialization` dependencies to Gradle configuration.
* Migrate UI components, scaffold, and theme from Compose Material to Material 3. * Update project dependencies including Kotlin, AGP, Compose BOM, JankStats, and Navigation3. * Upgrade Java target and source compatibility to Java 21. * Enable code minification (`isMinifyEnabled`) and resource shrinking (`isShrinkResources`) for release builds. * Move `android.intent.action.MAIN` intent filter to `JankAggregatorActivity`. * Remove unused dependencies and unused imports across the sample app.
mlykotom
approved these changes
Aug 7, 2026
| } | ||
| } | ||
|
|
||
| // [START aggregator_tracking_enabled] |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
we used these with includecode on DAC. pls make sure they either aren't needed anymore, or they should be reworked on DAC (this is the same as the android/snippets repo uses)
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Yup, this is in line with DAC updates
Sorry, something went wrong.
|
|
||
| setContent { | ||
| jankStats = remember { | ||
| JankStats.createAndTrack(window, jankFrameListener) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think the window, jankFrameListener should be part of remember as keys ?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Yes, you are right. Updated
Sorry, something went wrong.
Comment thread
JankStatsSample/gradle/libs.versions.toml
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modernizes the JankStats sample app by migrating from the legacy View-based and Fragment-based UI architecture to a fully Jetpack Compose-based navigation and UI structure. It also updates the project to use newer Android SDK versions, upgrades dependencies, and removes obsolete code. These changes improve maintainability, leverage the latest Android features, and simplify the codebase.
Migration to Jetpack Compose and Navigation3:
Dependency and Build System Updates:
Manifest and Theming Adjustments:
These changes collectively modernize the sample app, reduce technical debt, and provide a better foundation for Compose-based development.