fix(core): set `ngDevMode` to `false` when calling `enableProdMode()`… · angular/angular@922f492 · GitHub

angular / angular Public

• Notifications You must be signed in to change notification settings
• Fork 27.4k
• Star 101k

• Code
• Issues 990
• Pull requests 150
• Discussions
• Actions
• Projects
• Security and quality 28
• Insights

Additional navigation options

Commit 922f492

Browse filesBrowse the repository at this point in the historyBrowse files

alan-agius4

authored and

alxhub

committed

fix(core): set ngDevMode to false when calling enableProdMode() (#40124)

The `ngDevMode` description also mentions that calling `enableProdMode` will set this the value to `false`. https://github.com/angular/angular/blob/4610093c87975b6355f31a9c849351129908783a/packages/core/src/util/ng_dev_mode.ts#L22 which is currently not the case. PR Close #40124

1 parent 0aa220b commit 922f492
Copy full SHA for 922f492

1 file changed

+9Lines changed: 9 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/core/src/util
  • is_dev_mode.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/core/src/util/is_dev_mode.ts‎

Copy file name to clipboardExpand all lines: packages/core/src/util/is_dev_mode.ts

+9Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -6,6 +6,8 @@
6	6	* found in the LICENSE file at https://angular.io/license
7	7	*/
8	8
	9	+ import {global} from './global';
	10	+
9	11	/**
10	12	* This file is used to control if the default rendering pipeline should be `ViewEngine` or `Ivy`.
11	13	*
@@ -44,5 +46,12 @@ export function enableProdMode(): void {
44	46	if (_runModeLocked) {
45	47	throw new Error('Cannot enable prod mode after platform setup.');
46	48	}
	49	+
	50	+ // The below check is there so when ngDevMode is set via terser
	51	+ // `global['ngDevMode'] = false;` is also dropped.
	52	+ if (typeof ngDevMode === undefined || !!ngDevMode) {
	53	+ global['ngDevMode'] = false;
	54	+ }
	55	+
47	56	_devMode = false;
48	57	}

0 commit comments

Comments

0 (0)