FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(core): set `ngDevMode` to `false` when calling `enableProdMode()` by alan-agius4 · Pull Request #40124 · angular/angular · GitHub

/ angular Public

fix(core): set ngDevMode to false when calling enableProdMode() - #40124

Closed
alan-agius4 wants to merge 1 commit into
angular:masterfrom
alan-agius4:prod-mode-ng-dev-mode
ConversationCommits (1)ChecksFiles changed
Closed

fix(core): set ngDevMode to false when calling enableProdMode()#40124
alan-agius4 wants to merge 1 commit into
angular:masterfrom
alan-agius4:prod-mode-ng-dev-mode

Conversation

alan-agius4 commented Dec 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Currently, the global ngDevMode is set to false when using the Angular CLI optimization option. This option sets the globals via terser using the Compiler CLI private tooling API

angular/packages/compiler-cli/src/tooling.ts

Lines 25 to 34 in d39d64c

export const GLOBAL_DEFS_FOR_TERSER = {
ngDevMode: false,
ngI18nClosureMode: false,
};
export const GLOBAL_DEFS_FOR_TERSER_WITH_AOT = {
...GLOBAL_DEFS_FOR_TERSER,
ngJitMode: false,
};
.

It is not documented that users not using the Angular CLI or using Angular Universal without optimization need to manually set to false as otherwise they will be vulnerable to XHR attacks.

The ngDevMode description also mentions that calling enableProdMode will set the value to false.

angular/packages/core/src/util/ng_dev_mode.ts

Line 22 in 4610093

* - The user calls `enableProdMode()`.
which is currently not the case.

Closes #37644

alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release action: time-zone labels Dec 15, 2020
ngbot Bot modified the milestone: Backlog Dec 15, 2020
google-cla Bot added the cla: yes label Dec 15, 2020
pullapprove Bot requested a review from atscott December 15, 2020 08:08
alan-agius4 requested review from mhevery and removed request for atscott December 15, 2020 08:14
fix(core): set ngDevMode to false when calling enableProdMode()
d34fcdc 
The `ngDevMode` description also mentions that calling `enableProdMode` will set this the value to `false`.
https://github.com/angular/angular/blob/4610093c87975b6355f31a9c849351129908783a/packages/core/src/util/ng_dev_mode.ts#L22 which is currently not the case.

alan-agius4 commented Dec 15, 2020

Copy link
Copy Markdown
Contributor Author

FYI: @kyliau and @mgechev.

sod commented Dec 15, 2020

Copy link
Copy Markdown
Contributor

fixes #37644
fixes #36692

alan-agius4 linked an issue Dec 15, 2020 that may be closed by this pull request
Use ngDevMode to tree shake error messages in pipes #40096
Closed
alan-agius4 removed a link to an issue Dec 15, 2020
Use ngDevMode to tree shake error messages in pipes #40096
Closed
alan-agius4 added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 15, 2020
IgorMinar approved these changes Dec 15, 2020
View reviewed changes

IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

kyliau added the target: lts This PR is targeting a version currently in long-term support label Dec 15, 2020

AndrewKushnir commented Dec 15, 2020

Copy link
Copy Markdown
Contributor

Presubmit.

AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Dec 16, 2020

AndrewKushnir commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

FYI, presubmit went well for the changes in this PR.

@kyliau @alan-agius4 there are 2 target labels on this PR and the tooling does not support a single PR targeting multiple
trains/versions, see #40156. I will remove the "target: lts" for now (keeping just "target: patch") so this PR can be merged. Could you please create a separate PR if we need to land this change in LTS branch as well?

Thank you.

AndrewKushnir removed the target: lts This PR is targeting a version currently in long-term support label Dec 16, 2020

alan-agius4 commented Dec 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks @AndrewKushnir, I’ll create the PRs to target LTS branches tomorrow as I don’t have access to my laptop at the moment.

kyliau commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

cherry pick for v9 lts: #40159
cherry pick for v10 lts: #40160

alxhub pushed a commit that referenced this pull request Dec 16, 2020
fix(core): set ngDevMode to false when calling enableProdMode() (…
922f492 
…#40124)

The `ngDevMode` description also mentions that calling `enableProdMode` will set this the value to `false`.
https://github.com/angular/angular/blob/4610093c87975b6355f31a9c849351129908783a/packages/core/src/util/ng_dev_mode.ts#L22 which is currently not the case.

PR Close #40124
alxhub closed this in 70b4816 Dec 16, 2020
alan-agius4 deleted the prod-mode-ng-dev-mode branch December 17, 2020 07:05
sod mentioned this pull request Dec 18, 2020
Closed

angular-automatic-lock-bot Bot commented Jan 17, 2021

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jan 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
mhevery mhevery approved these changes
IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes core: bootstrap target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

mark enableProdMode as deprecated and output a warning that it should not be used anymore

6 participants

Back | FazBrowse Home | New Git URL