FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(dev-infra): detect multiple target labels as invalid by josephperrott · Pull Request #40156 · angular/angular · GitHub

/ angular Public

fix(dev-infra): detect multiple target labels as invalid - #40156

Closed
josephperrott wants to merge 3 commits into
angular:masterfrom
josephperrott:multiple-target-error
ConversationCommits (3)ChecksFiles changed
Closed

fix(dev-infra): detect multiple target labels as invalid#40156
josephperrott wants to merge 3 commits into
angular:masterfrom
josephperrott:multiple-target-error

Conversation

josephperrott commented Dec 16, 2020

Copy link
Copy Markdown
Member

When multiple target labels are applied to a PR, it should be considered
invalid as our tooling does not support a single PR targetting multiple
trains/versions.

fix(dev-infra): detect multiple target labels as invalid
26ff23a 
When multiple target labels are applied to a PR, it should be considered
invalid as our tooling does not support a single PR targetting multiple
trains/versions.
josephperrott added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) labels Dec 16, 2020
ngbot Bot modified the milestone: Backlog Dec 16, 2020
google-cla Bot added the cla: yes label Dec 16, 2020
AndrewKushnir mentioned this pull request Dec 16, 2020
Closed
gkalpak reviewed Dec 16, 2020
View reviewed changes

gkalpak left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

our tooling does not support a single PR targetting multiple trains/versions

I think this part of the commit sounds a little confusing. We do support merging into multiple trains/versions. For example, the target: patch label could result in merging into master, RC and patch. The commit message could be a little more clear on what the tooling does not support (multiple target labels?).

Otherwise lgtm 👍

devversion approved these changes Dec 17, 2020
View reviewed changes

devversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. One minor nit.

Comment thread dev-infra/pr/merge/target-label.ts
josephperrott marked this pull request as ready for review January 7, 2021 18:29
gkalpak suggested changes Jan 8, 2021
View reviewed changes
Comment thread dev-infra/pr/check-target-branches/check-target-branches.ts
Comment thread dev-infra/pr/merge/pull-request.ts
Comment thread dev-infra/pr/merge/target-label.ts Outdated
gkalpak approved these changes Jan 8, 2021
View reviewed changes

gkalpak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM (as soon as CI is happy) 🚀

josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 8, 2021
atscott pushed a commit that referenced this pull request Jan 11, 2021
fix(dev-infra): detect multiple target labels as invalid (#40156)
e88828f 
When multiple target labels are applied to a PR, it should be considered
invalid as our tooling does not support a single PR targetting multiple
trains/versions.

PR Close #40156
atscott closed this in 3d7e207 Jan 11, 2021

angular-automatic-lock-bot Bot commented Feb 11, 2021

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 11, 2021
josephperrott deleted the multiple-target-error branch August 31, 2023 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

devversion devversion approved these changes
+1 more reviewer
gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL