FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(core): set `ngDevMode` to `false` when calling `enableProdMode()` by kyliau · Pull Request #40160 · angular/angular · GitHub

/ angular Public

fix(core): set ngDevMode to false when calling enableProdMode() - #40160

Closed
kyliau wants to merge 1 commit into
angular:10.2.xfrom
kyliau:10.2.x
ConversationCommits (1)ChecksFiles changed
Closed

fix(core): set ngDevMode to false when calling enableProdMode()#40160
kyliau wants to merge 1 commit into
angular:10.2.xfrom
kyliau:10.2.x

Conversation

kyliau commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

The ngDevMode description also mentions that calling enableProdMode will set this the value to false.

angular/packages/core/src/util/ng_dev_mode.ts

Line 22 in 4610093

* - The user calls `enableProdMode()`.
which is currently not the case.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fix(core): set ngDevMode to false when calling enableProdMode()
487eac5 
The `ngDevMode` description also mentions that calling `enableProdMode` will set this the value to `false`.
https://github.com/angular/angular/blob/4610093c87975b6355f31a9c849351129908783a/packages/core/src/util/ng_dev_mode.ts#L22 which is currently not the case.

google-cla Bot commented Dec 16, 2020

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla Bot added the cla: no label Dec 16, 2020
pullapprove Bot requested a review from mhevery December 16, 2020 21:07
kyliau removed the cla: no label Dec 16, 2020
kyliau mentioned this pull request Dec 16, 2020
Closed
kyliau added cla: yes target: lts This PR is targeting a version currently in long-term support labels Dec 16, 2020
kyliau added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: merge The PR is ready for merge by the caretaker labels Dec 16, 2020
ngbot Bot added the action: merge The PR is ready for merge by the caretaker label Dec 16, 2020

alxhub commented Dec 16, 2020

Copy link
Copy Markdown
Member

Closed by commit 90570c0

alxhub closed this Dec 16, 2020
alxhub pushed a commit that referenced this pull request Dec 16, 2020
fix(core): set ngDevMode to false when calling enableProdMode() (…
90570c0 
…#40160)

The `ngDevMode` description also mentions that calling `enableProdMode` will set this the value to `false`.
https://github.com/angular/angular/blob/4610093c87975b6355f31a9c849351129908783a/packages/core/src/util/ng_dev_mode.ts#L22 which is currently not the case.

PR Close #40160
kyliau deleted the 10.2.x branch December 16, 2020 22:32

angular-automatic-lock-bot Bot commented Jan 16, 2021

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jan 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
mhevery mhevery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: lts This PR is targeting a version currently in long-term support

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL