FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: update bazel remote build config and documentation by josephperrott · Pull Request #33109 · angular/angular · GitHub

/ angular Public

build: update bazel remote build config and documentation - #33109

Closed
josephperrott wants to merge 6 commits into
angular:masterfrom
josephperrott:remote-update
ConversationCommits (6)ChecksFiles changed
Closed

build: update bazel remote build config and documentation#33109
josephperrott wants to merge 6 commits into
angular:masterfrom
josephperrott:remote-update

Conversation

josephperrott commented Oct 11, 2019

Copy link
Copy Markdown
Member

No description provided.

josephperrott added area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release labels Oct 11, 2019
josephperrott requested a review from a team October 11, 2019 19:06
ngbot Bot added this to the needsTriage milestone Oct 11, 2019
josephperrott force-pushed the remote-update branch 2 times, most recently from 0f2047a to 272a89b Compare October 11, 2019 19:34
devversion reviewed Oct 17, 2019
View reviewed changes
Comment thread docs/DEVELOPER.md Outdated
Comment thread scripts/local-dev/setup-rbe.sh Outdated
Comment thread scripts/local-dev/setup-rbe.sh Outdated
Comment thread scripts/local-dev/setup-rbe.sh Outdated
Comment thread scripts/local-dev/setup-rbe.sh Outdated
Comment thread scripts/local-dev/setup-rbe.sh Outdated
josephperrott force-pushed the remote-update branch 5 times, most recently from b728e9a to 895727d Compare October 17, 2019 22:08
devversion reviewed Oct 17, 2019
View reviewed changes
Comment thread docs/DEVELOPER.md Outdated
devversion approved these changes Oct 17, 2019
View reviewed changes

devversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Two minor nits

Comment thread scripts/local-dev/get-email Outdated
IgorMinar approved these changes Oct 18, 2019
View reviewed changes

IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm, except for

  • the material test failure. Is that a flake?
  • do we need to advertise more visibly that people should run scripts/local-dev/setup-rbe.sh ?

josephperrott commented Oct 21, 2019

Copy link
Copy Markdown
Member Author

The material test failure is a flake.

I feel that we can advertise by emailing everyone on the angular.io domain to let them know its an option for them. Since only google.com and angular.io users are able to use it I am not sure where else we can advertise appropriately.

josephperrott force-pushed the remote-update branch 2 times, most recently from 1bc9d7c to 4078a36 Compare October 21, 2019 16:22
josephperrott added the action: merge The PR is ready for merge by the caretaker label Oct 21, 2019

matsko commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

@josephperrott this fails on patch. Please create a new PR targeted directly to that branch.

matsko added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Oct 21, 2019
matsko closed this in 931739a Oct 21, 2019
matsko pushed a commit that referenced this pull request Oct 21, 2019
build: remove cache upload and download flags from build:remote confi…
2ea52b0 
…g as they are redundant (#33109)

PR Close #33109
matsko pushed a commit that referenced this pull request Oct 21, 2019
build: migrate to using google_default_credentials and update setup-r…
37a8741 
…be script (#33109)

PR Close #33109
matsko pushed a commit that referenced this pull request Oct 21, 2019
docs: update DEVELOPER.md to include information about RBE and remote…
3b643b8 
… caching (#33109)

PR Close #33109
matsko pushed a commit that referenced this pull request Oct 21, 2019
build: update circleci config to handle GOOGLE_APPLICATION_CREDENTIAL…
fa0ab38 
…S for all linux bazel builds (#33109)

PR Close #33109
matsko pushed a commit that referenced this pull request Oct 21, 2019
build: address comments, restructure setup-rbe.sh script (#33109)
418e9cf 
PR Close #33109
josephperrott mentioned this pull request Oct 21, 2019
Closed

angular-automatic-lock-bot Bot commented Nov 21, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 21, 2019
josephperrott deleted the remote-update branch March 18, 2020 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

devversion devversion approved these changes
+1 more reviewer
IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL